Change in coreboot[master]: drivers/intel/fsp1_1/cache_as_ram.S: Use _car_stack area for stack
Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47737 )
Change subject: drivers/intel/fsp1_1/cache_as_ram.S: Use _car_stack area for stack ......................................................................
drivers/intel/fsp1_1/cache_as_ram.S: Use _car_stack area for stack
Top of Temp RAM is used as bootloader stack, which is the _car_region_end area. This area is not equal to CAR stack area as defined in car.ld file.
Use _ecar_stack (end of CAR stack) as starting stack location.
Tested VBOOT, Vendorboot security and no security on Facebook FBG1701.
Change-Id: I16b077f60560de334361b1f0d3758ab1a5cbe895 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/drivers/intel/fsp1_1/cache_as_ram.S 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/47737/1
diff --git a/src/drivers/intel/fsp1_1/cache_as_ram.S b/src/drivers/intel/fsp1_1/cache_as_ram.S index 31c3580..3be9eb9 100644 --- a/src/drivers/intel/fsp1_1/cache_as_ram.S +++ b/src/drivers/intel/fsp1_1/cache_as_ram.S @@ -133,7 +133,7 @@ jne halt2
/* Setup bootloader stack */ - movl %edx, %esp + movl $_ecar_stack, %esp
/* * ebp: FSP_INFO_HEADER address
Hello Michał Żygowski, Lee Leahy, Huang Jin, Arthur Heymans, Patrick Rudolph, Wim Vervoorn, Piotr Król,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47737
to look at the new patch set (#2).
Change subject: drivers/intel/fsp1_1/cache_as_ram.S: Use _car_stack area for stack ......................................................................
drivers/intel/fsp1_1/cache_as_ram.S: Use _car_stack area for stack
Top of Temp RAM is used as bootloader stack, which is the _car_region_end area. This area is not equal to CAR stack area as defined in car.ld file.
Use _ecar_stack (end of CAR stack) as starting stack location.
Tested VBOOT, Vendorboot security and no security on Facebook FBG1701.
Change-Id: I16b077f60560de334361b1f0d3758ab1a5cbe895 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/drivers/intel/fsp1_1/cache_as_ram.S 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/47737/2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47737 )
Change subject: drivers/intel/fsp1_1/cache_as_ram.S: Use _car_stack area for stack ......................................................................
Patch Set 2: Code-Review+2
I'll drop CB:37276, which did the same.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47737 )
Change subject: drivers/intel/fsp1_1/cache_as_ram.S: Use _car_stack area for stack ......................................................................
Patch Set 2:
Patch Set 2: Code-Review+2
I'll drop CB:37276, which did the same.
I just noticed your patch. (Listed as merge conflict)
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47737 )
Change subject: drivers/intel/fsp1_1/cache_as_ram.S: Use _car_stack area for stack ......................................................................
Patch Set 2:
You might be interested in CB:46884 to report what FSP-T returns.
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47737 )
Change subject: drivers/intel/fsp1_1/cache_as_ram.S: Use _car_stack area for stack ......................................................................
Patch Set 2: Code-Review+2
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47737 )
Change subject: drivers/intel/fsp1_1/cache_as_ram.S: Use _car_stack area for stack ......................................................................
Patch Set 2: Code-Review+2
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47737 )
Change subject: drivers/intel/fsp1_1/cache_as_ram.S: Use _car_stack area for stack ......................................................................
Patch Set 2: Code-Review+2
Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47737 )
Change subject: drivers/intel/fsp1_1/cache_as_ram.S: Use _car_stack area for stack ......................................................................
drivers/intel/fsp1_1/cache_as_ram.S: Use _car_stack area for stack
Top of Temp RAM is used as bootloader stack, which is the _car_region_end area. This area is not equal to CAR stack area as defined in car.ld file.
Use _ecar_stack (end of CAR stack) as starting stack location.
Tested VBOOT, Vendorboot security and no security on Facebook FBG1701.
Change-Id: I16b077f60560de334361b1f0d3758ab1a5cbe895 Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47737 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-by: Michał Żygowski michal.zygowski@3mdeb.com Reviewed-by: Christian Walter christian.walter@9elements.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/intel/fsp1_1/cache_as_ram.S 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Wim Vervoorn: Looks good to me, approved Arthur Heymans: Looks good to me, approved Michał Żygowski: Looks good to me, approved Christian Walter: Looks good to me, approved
diff --git a/src/drivers/intel/fsp1_1/cache_as_ram.S b/src/drivers/intel/fsp1_1/cache_as_ram.S index 31c3580..3be9eb9 100644 --- a/src/drivers/intel/fsp1_1/cache_as_ram.S +++ b/src/drivers/intel/fsp1_1/cache_as_ram.S @@ -133,7 +133,7 @@ jne halt2
/* Setup bootloader stack */ - movl %edx, %esp + movl $_ecar_stack, %esp
/* * ebp: FSP_INFO_HEADER address
-
Arthur Heymans (Code Review) -
Christian Walter (Code Review)
-
Frans Hendriks (Code Review)
-
Michał Żygowski (Code Review)
-
Wim Vervoorn (Code Review)