Attention is currently required from: shkim, Henry Sun, SH Kim, Paul Menzel, Simon Yang, Edward Doan, Karthik Ramasubramanian.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60190 )
Change subject: mb/google/dedede/var/bugzzy: Initialize display signals on user mode
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/dedede/variants/bugzzy/ramstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135881):
https://review.coreboot.org/c/coreboot/+/60190/comment/60b6fdf3_3e6e793a
PS6, Line 71: BOOT_STATE_INIT_ENTRY(BS_POST_DEVICE, BS_ON_ENTRY, wa_init_display_signal, NULL);
adding a line without newline at end of file
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60190
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa4d16deb932f43ae1ab33ff5b4e74120ab670db
Gerrit-Change-Number: 60190
Gerrit-PatchSet: 6
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Edward Doan
edoan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Simon Yang
simon1.yang@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: shkim
sh_.kim@samsung.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Simon Yang
simon1.yang@intel.corp-partner.google.com
Gerrit-Attention: Edward Doan
edoan@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 20 Dec 2021 08:23:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment