Attention is currently required from: Bora Guvendik, Li1 Feng, Pranava Y N, YH Lin.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84998?usp=email )
Change subject: mb/google/fatcat: Add ISH support with FW_CONFIG toggle
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84998/comment/79f9ff8c_9fc5cbb7?usp... :
PS1, Line 236: chip drivers/intel/ish
: register "firmware_name" = ""ish_fw.bin""
: register "add_acpi_dma_property" = "true"
Correct. From PTL, there is new ISH loader code implemented. Kernel will handle ISH image name. We don't have to add in CB.
let me remove this entry in that case.
done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84998?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1a9734139a49be982a7dd43d5afd92e7fea6b29c
Gerrit-Change-Number: 84998
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Li1 Feng
li1.feng@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Li1 Feng
li1.feng@intel.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Wed, 06 Nov 2024 14:43:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bora Guvendik
bora.guvendik@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Li1 Feng
li1.feng@intel.com