Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/28286 )
Change subject: fsp/fsp2_0/coffeelake: Update CFL FSP headers ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2: Code-Review+2
(1 comment)
I am not too sure all the other header file revision is synced with version on coreboot.org, so didn't dare to include all the headers file yet. Add Nathaniel in to reviewer to get his opinion from fsp side. In the mean time, I can drop the script from this commit and have an follow up one to update all fsp headers together.
My concern wasn't so much about the other headers, just about making the script more general and put it in a more easily discovered location.
Although, keeping it all in sync would be nice, yes. Or, once/if redistribution is settled, just use them from the repo (that could be put in 3rdparty/fsp-blobs or whatever). But that's all stuff for a separate change.
-
Patrick Georgi (Code Review)