[M] Change in coreboot[main]: soc/mediatek/mt8196: Initialize MCUPM

[agogo (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.

agogo has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85888?usp=email )

Change subject: soc/mediatek/mt8196: Initialize MCUPM
......................................................................

Patch Set 2:

(1 comment)

File src/soc/mediatek/mt8196/mcupm.c:

https://review.coreboot.org/c/coreboot/+/85888/comment/1e89e035_3f3dea5a?usp... :
PS1, Line 39: 	/* set CPUEB_STATE_VALID = 1 */
            : 	setbits32p(SPM_MCUPM_SPMC_CON, CPUEB_STATE_VALID);
            : 
            : 	/* polling CPUEB_STATE_FINISH_ACK = 1 */
            : 	if (!retry(POLLING_ACK_TIME,
            : 		   (read32p(SPM_MCUPM_SPMC_CON) & CPUEB_STATE_FINISH_ACK) ==
            : 		   CPUEB_STATE_FINISH_ACK, udelay(1))) {
            : 		printk(BIOS_WARNING,
            : 		       "[EB_SPMC] Polling ACK timeout, %#x\n",
            : 		       read32p(SPM_MCUPM_SPMC_CON));
            : 		return -1;
            : 	}
            : 
            : 	/* set CPUEB_STATE_VALID = 0 */
            : 	clrbits32p(SPM_MCUPM_SPMC_CON, CPUEB_STATE_VALID);
            : 
            : 	/* polling CPUEB_STATE_FINISH_ACK = 0 */
            : 	if (!retry(POLLING_ACK_TIME,
            : 		   (read32p(SPM_MCUPM_SPMC_CON) & CPUEB_STATE_FINISH_ACK) !=
            : 		   CPUEB_STATE_FINISH_ACK, udelay(1))) {
            : 		printk(BIOS_WARNING,
            : 		       "[EB_SPMC] Polling ACK timeout, %#x\n",
            : 		       read32p(SPM_MCUPM_SPMC_CON));
            : 		return -1;
            : 	}
> This modification is not necessary

Only used here, no need to create an additional API