Attention is currently required from: Angel Pons, Arthur Heymans, Lean Sheng Tan.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69383 )
Change subject: soc/intel/ehl: Add MDIO operation to TSN GbE device
......................................................................
Patch Set 12:
(2 comments)
File src/soc/intel/elkhartlake/tsn_gbe.c:
https://review.coreboot.org/c/coreboot/+/69383/comment/7ac3378d_075409b8
PS12, Line 104: (void *)(uintptr_t)gbe_tsn_res->base
Use res2mmio
I will change this from 'gbe_tsn_res' to 'res2mmio'.
https://review.coreboot.org/c/coreboot/+/69383/comment/d739bc34_ccb8c8e9
PS12, Line 161: &
& is not needed with function pointers.
Are you sure? If I do this without address operator '&', I get a compiler error 'incompatible types'.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69383
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d1b9dd2f2ba8c18291fff314c13f0c3851784aa
Gerrit-Change-Number: 69383
Gerrit-PatchSet: 12
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Tue, 22 Nov 2022 13:13:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment