Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37241 )
Change subject: Documentation: Remove redundant 'documentation' ......................................................................
Documentation: Remove redundant 'documentation'
We are already in documentation so it should be obvious that other links point to other documentation.
Change-Id: I7a021a09bdb88418ec85dbf433465f26445057d0 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M Documentation/index.md 1 file changed, 10 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/37241/1
diff --git a/Documentation/index.md b/Documentation/index.md index 8a996b9..3ed6bd3 100644 --- a/Documentation/index.md +++ b/Documentation/index.md @@ -174,17 +174,17 @@ * [GPIO toggling in ACPI AML](acpi/gpio.md) * [Adding devices to a device tree](acpi/devicetree.md) * [Native Graphics Initialization with libgfxinit](gfx/libgfxinit.md) -* [Display panel-specific documentation](gfx/display-panel.md) -* [Architecture-specific documentation](arch/index.md) -* [Platform independend drivers documentation](drivers/index.md) -* [Northbridge-specific documentation](northbridge/index.md) -* [System on Chip-specific documentation](soc/index.md) -* [Mainboard-specific documentation](mainboard/index.md) -* [Payload-specific documentation](lib/payloads/index.md) -* [Library-specific documentation](lib/index.md) +* [Display panel](gfx/display-panel.md) +* [CPU Architecture](arch/index.md) +* [Platform independend drivers](drivers/index.md) +* [Northbridge](northbridge/index.md) +* [System on Chip](soc/index.md) +* [Mainboard](mainboard/index.md) +* [Payloads](lib/payloads/index.md) +* [Libraries](lib/index.md) * [Security](security/index.md) -* [SuperIO-specific documentation](superio/index.md) -* [Vendorcode-specific documentation](vendorcode/index.md) +* [SuperIO](superio/index.md) +* [Vendorcode](vendorcode/index.md) * [Utilities](util.md) * [Release notes for past releases](releases/index.md) * [Flashing firmware tutorial](flash_tutorial/index.md)
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37241 )
Change subject: Documentation: Remove redundant 'documentation' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37241/1/Documentation/index.md File Documentation/index.md:
https://review.coreboot.org/c/coreboot/+/37241/1/Documentation/index.md@184 PS1, Line 184: Libraries Should maybe say 'Internal libraries'.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37241 )
Change subject: Documentation: Remove redundant 'documentation' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37241/1/Documentation/index.md File Documentation/index.md:
https://review.coreboot.org/c/coreboot/+/37241/1/Documentation/index.md@184 PS1, Line 184: Libraries
Should maybe say 'Internal libraries'.
We're not collecting documentation for external libraries, so that would be redundant, too?
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37241 )
Change subject: Documentation: Remove redundant 'documentation' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37241/1/Documentation/index.md File Documentation/index.md:
https://review.coreboot.org/c/coreboot/+/37241/1/Documentation/index.md@184 PS1, Line 184: Libraries
We're not collecting documentation for external libraries, so that would be redundant, too?
I meant it as a distinction between internal API's and things that coreboot exports?
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37241 )
Change subject: Documentation: Remove redundant 'documentation' ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/37241/1/Documentation/index.md File Documentation/index.md:
https://review.coreboot.org/c/coreboot/+/37241/1/Documentation/index.md@183 PS1, Line 183: * [Payloads](lib/payloads/index.md) Not necessarily for this commit, but this seems to be more about payload support, not payloads.
https://review.coreboot.org/c/coreboot/+/37241/1/Documentation/index.md@184 PS1, Line 184: Libraries
We're not collecting documentation for external libraries, so that would be redundant, too? […]
To me it seems to be more generally about infrastructure code. There is also `lib/abi-data-consumption` which is neither about libraries nor internal.
Name changes probably should be in a separate commit anyway.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37241 )
Change subject: Documentation: Remove redundant 'documentation' ......................................................................
Documentation: Remove redundant 'documentation'
We are already in documentation so it should be obvious that other links point to other documentation.
Change-Id: I7a021a09bdb88418ec85dbf433465f26445057d0 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/37241 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M Documentation/index.md 1 file changed, 10 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/Documentation/index.md b/Documentation/index.md index 8a996b9..3ed6bd3 100644 --- a/Documentation/index.md +++ b/Documentation/index.md @@ -174,17 +174,17 @@ * [GPIO toggling in ACPI AML](acpi/gpio.md) * [Adding devices to a device tree](acpi/devicetree.md) * [Native Graphics Initialization with libgfxinit](gfx/libgfxinit.md) -* [Display panel-specific documentation](gfx/display-panel.md) -* [Architecture-specific documentation](arch/index.md) -* [Platform independend drivers documentation](drivers/index.md) -* [Northbridge-specific documentation](northbridge/index.md) -* [System on Chip-specific documentation](soc/index.md) -* [Mainboard-specific documentation](mainboard/index.md) -* [Payload-specific documentation](lib/payloads/index.md) -* [Library-specific documentation](lib/index.md) +* [Display panel](gfx/display-panel.md) +* [CPU Architecture](arch/index.md) +* [Platform independend drivers](drivers/index.md) +* [Northbridge](northbridge/index.md) +* [System on Chip](soc/index.md) +* [Mainboard](mainboard/index.md) +* [Payloads](lib/payloads/index.md) +* [Libraries](lib/index.md) * [Security](security/index.md) -* [SuperIO-specific documentation](superio/index.md) -* [Vendorcode-specific documentation](vendorcode/index.md) +* [SuperIO](superio/index.md) +* [Vendorcode](vendorcode/index.md) * [Utilities](util.md) * [Release notes for past releases](releases/index.md) * [Flashing firmware tutorial](flash_tutorial/index.md)
-
Arthur Heymans (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)