Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42138 )
Change subject: mb/scaleway/tagada: Move override of SMBIOS_ENCLOSURE_TYPE ......................................................................
mb/scaleway/tagada: Move override of SMBIOS_ENCLOSURE_TYPE
Change-Id: Iaefeccadb82106667a5108a2c77e538474ae18c2 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/scaleway/tagada/Kconfig M src/mainboard/scaleway/tagada/ramstage.c 2 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/42138/1
diff --git a/src/mainboard/scaleway/tagada/Kconfig b/src/mainboard/scaleway/tagada/Kconfig index 34473a8..cbbb6ae 100644 --- a/src/mainboard/scaleway/tagada/Kconfig +++ b/src/mainboard/scaleway/tagada/Kconfig @@ -24,8 +24,4 @@ help Location of BMC SERIAL information.
-config SMBIOS_ENCLOSURE_TYPE - hex - default 0x19 # SMBIOS_ENCLOSURE_MULTI_SYSTEM_CHASSIS - endif # BOARD_SCALEWAY_TAGADA diff --git a/src/mainboard/scaleway/tagada/ramstage.c b/src/mainboard/scaleway/tagada/ramstage.c index 5cad2ba..6d5d3ff 100644 --- a/src/mainboard/scaleway/tagada/ramstage.c +++ b/src/mainboard/scaleway/tagada/ramstage.c @@ -72,6 +72,11 @@ return SMBIOS_BOARD_TYPE_SERVER_BLADE; }
+smbios_enclosure_type smbios_mainboard_enclosure_type(void) +{ + return SMBIOS_ENCLOSURE_MULTI_SYSTEM_CHASSIS; +} + /* Add any mainboard specific information for dimm */ void mainboard_add_dimm_info( struct memory_info *mem_info,
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42138 )
Change subject: mb/scaleway/tagada: Move override of SMBIOS_ENCLOSURE_TYPE ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42138/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42138/1//COMMIT_MSG@7 PS1, Line 7: mb/scaleway/tagada: Move override of SMBIOS_ENCLOSURE_TYPE Should we define a new SYSTEM_TYPE_MULTI_SYSTEM_CHASSIS, or is it not worth the hassle for one board?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42138 )
Change subject: mb/scaleway/tagada: Move override of SMBIOS_ENCLOSURE_TYPE ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42138/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42138/1//COMMIT_MSG@7 PS1, Line 7: mb/scaleway/tagada: Move override of SMBIOS_ENCLOSURE_TYPE
Should we define a new SYSTEM_TYPE_MULTI_SYSTEM_CHASSIS, or is it not worth the hassle for one board […]
SYSTEM_TYPE_MULTI_SYSTEM_CHASSIS for Preferred_PM_Profile ? (if so, this thing doesn't exist in acpi specs)
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42138 )
Change subject: mb/scaleway/tagada: Move override of SMBIOS_ENCLOSURE_TYPE ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42138 )
Change subject: mb/scaleway/tagada: Move override of SMBIOS_ENCLOSURE_TYPE ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42138/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42138/1//COMMIT_MSG@7 PS1, Line 7: mb/scaleway/tagada: Move override of SMBIOS_ENCLOSURE_TYPE
SYSTEM_TYPE_MULTI_SYSTEM_CHASSIS for Preferred_PM_Profile ? […]
As per comments on CB:42141, SYSTEM_TYPE_xx is to be dropped, so no.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42138 )
Change subject: mb/scaleway/tagada: Move override of SMBIOS_ENCLOSURE_TYPE ......................................................................
mb/scaleway/tagada: Move override of SMBIOS_ENCLOSURE_TYPE
Change-Id: Iaefeccadb82106667a5108a2c77e538474ae18c2 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42138 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/mainboard/scaleway/tagada/Kconfig M src/mainboard/scaleway/tagada/ramstage.c 2 files changed, 5 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/scaleway/tagada/Kconfig b/src/mainboard/scaleway/tagada/Kconfig index 34473a8..cbbb6ae 100644 --- a/src/mainboard/scaleway/tagada/Kconfig +++ b/src/mainboard/scaleway/tagada/Kconfig @@ -24,8 +24,4 @@ help Location of BMC SERIAL information.
-config SMBIOS_ENCLOSURE_TYPE - hex - default 0x19 # SMBIOS_ENCLOSURE_MULTI_SYSTEM_CHASSIS - endif # BOARD_SCALEWAY_TAGADA diff --git a/src/mainboard/scaleway/tagada/ramstage.c b/src/mainboard/scaleway/tagada/ramstage.c index 5cad2ba..6d5d3ff 100644 --- a/src/mainboard/scaleway/tagada/ramstage.c +++ b/src/mainboard/scaleway/tagada/ramstage.c @@ -72,6 +72,11 @@ return SMBIOS_BOARD_TYPE_SERVER_BLADE; }
+smbios_enclosure_type smbios_mainboard_enclosure_type(void) +{ + return SMBIOS_ENCLOSURE_MULTI_SYSTEM_CHASSIS; +} + /* Add any mainboard specific information for dimm */ void mainboard_add_dimm_info( struct memory_info *mem_info,
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)