Change in coreboot[master]: mb/facebook/monolith: Add UNIFIED_MRC_CACHE region in fmd file
Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38130 )
Change subject: mb/facebook/monolith: Add UNIFIED_MRC_CACHE region in fmd file ......................................................................
mb/facebook/monolith: Add UNIFIED_MRC_CACHE region in fmd file
The RW_MRC_CACHE was not included in a UNIFIED_MRC_CACHE region which is expected by some parts of the code.
Add the UNIFIED_MRC_CACHE and include the RW_MRC_CACHE in this region.
BUG=N/A TEST=tested on facebook monolith
Change-Id: I1654ca210dc2a8e976d698fd8330641da23e8380 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/monolith/vboot-ro.fmd M src/mainboard/facebook/monolith/vboot-rw.fmd 2 files changed, 6 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/38130/1
diff --git a/src/mainboard/facebook/monolith/vboot-ro.fmd b/src/mainboard/facebook/monolith/vboot-ro.fmd index 989afcb..4abd883 100644 --- a/src/mainboard/facebook/monolith/vboot-ro.fmd +++ b/src/mainboard/facebook/monolith/vboot-ro.fmd @@ -6,7 +6,9 @@ } SI_BIOS@0x700000 0x900000 { MISC_RW@0x0 0x20000 { - RW_MRC_CACHE@0x0 0x10000 + UNIFIED_MRC_CACHE@0x0 0x10000 { + RW_MRC_CACHE@0x00000 0x10000 + } RW_VPD(PRESERVE)@0x010000 0x2000 RW_NVRAM(PRESERVE)@0x012000 0x6000 } diff --git a/src/mainboard/facebook/monolith/vboot-rw.fmd b/src/mainboard/facebook/monolith/vboot-rw.fmd index fd7811b..df2674b 100644 --- a/src/mainboard/facebook/monolith/vboot-rw.fmd +++ b/src/mainboard/facebook/monolith/vboot-rw.fmd @@ -6,7 +6,9 @@ } SI_BIOS@0x700000 0x900000 { MISC_RW@0x0 0x20000 { - RW_MRC_CACHE@0x0 0x10000 + UNIFIED_MRC_CACHE@0x0 0x10000 { + RW_MRC_CACHE@0x00000 0x10000 + } RW_VPD(PRESERVE)@0x010000 0x2000 RW_NVRAM(PRESERVE)@0x012000 0x6000 }
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38130 )
Change subject: mb/facebook/monolith: Add UNIFIED_MRC_CACHE region in fmd file ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38130 )
Change subject: mb/facebook/monolith: Add UNIFIED_MRC_CACHE region in fmd file ......................................................................
mb/facebook/monolith: Add UNIFIED_MRC_CACHE region in fmd file
The RW_MRC_CACHE was not included in a UNIFIED_MRC_CACHE region which is expected by some parts of the code.
Add the UNIFIED_MRC_CACHE and include the RW_MRC_CACHE in this region.
BUG=N/A TEST=tested on facebook monolith
Change-Id: I1654ca210dc2a8e976d698fd8330641da23e8380 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38130 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/monolith/vboot-ro.fmd M src/mainboard/facebook/monolith/vboot-rw.fmd 2 files changed, 6 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved
diff --git a/src/mainboard/facebook/monolith/vboot-ro.fmd b/src/mainboard/facebook/monolith/vboot-ro.fmd index 989afcb..4abd883 100644 --- a/src/mainboard/facebook/monolith/vboot-ro.fmd +++ b/src/mainboard/facebook/monolith/vboot-ro.fmd @@ -6,7 +6,9 @@ } SI_BIOS@0x700000 0x900000 { MISC_RW@0x0 0x20000 { - RW_MRC_CACHE@0x0 0x10000 + UNIFIED_MRC_CACHE@0x0 0x10000 { + RW_MRC_CACHE@0x00000 0x10000 + } RW_VPD(PRESERVE)@0x010000 0x2000 RW_NVRAM(PRESERVE)@0x012000 0x6000 } diff --git a/src/mainboard/facebook/monolith/vboot-rw.fmd b/src/mainboard/facebook/monolith/vboot-rw.fmd index fd7811b..df2674b 100644 --- a/src/mainboard/facebook/monolith/vboot-rw.fmd +++ b/src/mainboard/facebook/monolith/vboot-rw.fmd @@ -6,7 +6,9 @@ } SI_BIOS@0x700000 0x900000 { MISC_RW@0x0 0x20000 { - RW_MRC_CACHE@0x0 0x10000 + UNIFIED_MRC_CACHE@0x0 0x10000 { + RW_MRC_CACHE@0x00000 0x10000 + } RW_VPD(PRESERVE)@0x010000 0x2000 RW_NVRAM(PRESERVE)@0x012000 0x6000 }
-
Frans Hendriks (Code Review) -
Nico Huber (Code Review)
-
Wim Vervoorn (Code Review)