Change in ...coreboot[master]: vboot: remove functions which read vboot_handoff.out_flags
Joel Kitching has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33533
Change subject: vboot: remove functions which read vboot_handoff.out_flags ......................................................................
vboot: remove functions which read vboot_handoff.out_flags
These functions are no longer used and may be removed: * vboot_handoff_check_recovery_flag * vboot_get_handoff_flag
BUG=b:124141368, b:124192753 TEST=make clean && make test-abuild BRANCH=none
Change-Id: Ie05652ef1288eef74bd2e7e8bea79fd29d523859 Signed-off-by: Joel Kitching kitching@google.com --- M src/security/vboot/vboot_common.c M src/security/vboot/vboot_common.h 2 files changed, 0 insertions(+), 27 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/33533/1
diff --git a/src/security/vboot/vboot_common.c b/src/security/vboot/vboot_common.c index a18bf23..8456dcf 100644 --- a/src/security/vboot/vboot_common.c +++ b/src/security/vboot/vboot_common.c @@ -75,24 +75,6 @@ return 0; }
-static int vboot_get_handoff_flag(uint32_t flag) -{ - struct vboot_handoff *vbho; - - /* - * If vboot_handoff cannot be found, return default value of flag as 0. - */ - if (vboot_get_handoff_info((void **)&vbho, NULL)) - return 0; - - return !!(vbho->out_flags & flag); -} - -int vboot_handoff_check_recovery_flag(void) -{ - return vboot_get_handoff_flag(VB_INIT_OUT_ENABLE_RECOVERY); -} - /* ============================ VBOOT REBOOT ============================== */ void __weak vboot_platform_prepare_reboot(void) { diff --git a/src/security/vboot/vboot_common.h b/src/security/vboot/vboot_common.h index a3180c1d..241dc90 100644 --- a/src/security/vboot/vboot_common.h +++ b/src/security/vboot/vboot_common.h @@ -53,15 +53,6 @@ */ int vboot_get_handoff_info(void **addr, uint32_t *size);
-/* - * The following functions read vboot_handoff structure to obtain requested - * information. If vboot handoff is not available, 0 is returned by default. - * If vboot handoff is available: - * Returns 1 for flag if true - * Returns 0 for flag if false - */ -int vboot_handoff_check_recovery_flag(void); - /* ============================ VBOOT REBOOT ============================== */ /* * vboot_reboot handles the reboot requests made by vboot_reference library. It
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33533 )
Change subject: vboot: remove functions which read vboot_handoff.out_flags ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33533
to look at the new patch set (#2).
Change subject: vboot: remove functions which read vboot_handoff.out_flags ......................................................................
vboot: remove functions which read vboot_handoff.out_flags
These functions are no longer used and may be removed: * vboot_handoff_check_recovery_flag * vboot_get_handoff_flag
BUG=b:124141368, b:124192753 TEST=make clean && make test-abuild BRANCH=none
Change-Id: Ie05652ef1288eef74bd2e7e8bea79fd29d523859 Signed-off-by: Joel Kitching kitching@google.com --- M src/security/vboot/vboot_common.c M src/security/vboot/vboot_common.h 2 files changed, 0 insertions(+), 27 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/33533/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33533 )
Change subject: vboot: remove functions which read vboot_handoff.out_flags ......................................................................
Patch Set 2: Code-Review+2
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33533 )
Change subject: vboot: remove functions which read vboot_handoff.out_flags ......................................................................
Patch Set 3: Code-Review+2
Julius Werner has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33533 )
Change subject: vboot: remove functions which read vboot_handoff.out_flags ......................................................................
vboot: remove functions which read vboot_handoff.out_flags
These functions are no longer used and may be removed: * vboot_handoff_check_recovery_flag * vboot_get_handoff_flag
BUG=b:124141368, b:124192753 TEST=make clean && make test-abuild BRANCH=none
Change-Id: Ie05652ef1288eef74bd2e7e8bea79fd29d523859 Signed-off-by: Joel Kitching kitching@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/33533 Reviewed-by: Julius Werner jwerner@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/security/vboot/vboot_common.c M src/security/vboot/vboot_common.h 2 files changed, 0 insertions(+), 27 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Julius Werner: Looks good to me, approved
diff --git a/src/security/vboot/vboot_common.c b/src/security/vboot/vboot_common.c index a18bf23..8456dcf 100644 --- a/src/security/vboot/vboot_common.c +++ b/src/security/vboot/vboot_common.c @@ -75,24 +75,6 @@ return 0; }
-static int vboot_get_handoff_flag(uint32_t flag) -{ - struct vboot_handoff *vbho; - - /* - * If vboot_handoff cannot be found, return default value of flag as 0. - */ - if (vboot_get_handoff_info((void **)&vbho, NULL)) - return 0; - - return !!(vbho->out_flags & flag); -} - -int vboot_handoff_check_recovery_flag(void) -{ - return vboot_get_handoff_flag(VB_INIT_OUT_ENABLE_RECOVERY); -} - /* ============================ VBOOT REBOOT ============================== */ void __weak vboot_platform_prepare_reboot(void) { diff --git a/src/security/vboot/vboot_common.h b/src/security/vboot/vboot_common.h index 65a543c..241dc90 100644 --- a/src/security/vboot/vboot_common.h +++ b/src/security/vboot/vboot_common.h @@ -53,15 +53,6 @@ */ int vboot_get_handoff_info(void **addr, uint32_t *size);
-/* - * The following function reads vboot_handoff structure to obtain requested - * information. If vboot handoff is not available, 0 is returned by default. - * If vboot handoff is available: - * Returns 1 for flag if true - * Returns 0 for flag if false - */ -int vboot_handoff_check_recovery_flag(void); - /* ============================ VBOOT REBOOT ============================== */ /* * vboot_reboot handles the reboot requests made by vboot_reference library. It
-
Furquan Shaikh (Code Review) -
Joel Kitching (Code Review)
-
Julius Werner (Code Review)