Change in ...coreboot[master]: src/commonlib: Use 'include <stdlib.h>' when appropriate

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33679

Change subject: src/commonlib: Use 'include <stdlib.h>' when appropriate
......................................................................

src/commonlib: Use 'include <stdlib.h>' when appropriate

Also add some missing includes spotted by Jenkins

Change-Id: I40595df5cccd023aea486a3515c9efaf9b74ac49
Signed-off-by: Elyes HAOUAS 
---
M src/commonlib/fsp_relocate.c
M src/commonlib/include/commonlib/mem_pool.h
M src/commonlib/mem_pool.c
M src/commonlib/region.c
M src/commonlib/storage/bouncebuf.c
M src/commonlib/storage/sdhci.c
M src/commonlib/storage/sdhci_adma.c
7 files changed, 18 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/33679/1

diff --git a/src/commonlib/fsp_relocate.c b/src/commonlib/fsp_relocate.c
index 32e6b6d..a1b4be6 100644
--- a/src/commonlib/fsp_relocate.c
+++ b/src/commonlib/fsp_relocate.c
@@ -31,7 +31,7 @@
 #pragma pack(pop)

#include <commonlib/helpers.h>
-#include <stdlib.h>
+#include <stddef.h>
 #include <stdint.h>
 #include <string.h>

diff --git a/src/commonlib/include/commonlib/mem_pool.h b/src/commonlib/include/commonlib/mem_pool.h
index c21fa0e..acfcaea 100644
--- a/src/commonlib/include/commonlib/mem_pool.h
+++ b/src/commonlib/include/commonlib/mem_pool.h
@@ -18,6 +18,7 @@

#include <stddef.h>
 #include <stdint.h>
+#include <stdlib.h>

/*
  * The memory pool allows one to allocate memory from a fixed size buffer
diff --git a/src/commonlib/mem_pool.c b/src/commonlib/mem_pool.c
index cb3e726..0868830 100644
--- a/src/commonlib/mem_pool.c
+++ b/src/commonlib/mem_pool.c
@@ -15,6 +15,8 @@

#include <commonlib/helpers.h>
 #include <commonlib/mem_pool.h>
+#include <stddef.h>
+#include <stdlib.h>

void *mem_pool_alloc(struct mem_pool *mp, size_t sz)
 {
diff --git a/src/commonlib/region.c b/src/commonlib/region.c
index 541a125..8698457 100644
--- a/src/commonlib/region.c
+++ b/src/commonlib/region.c
@@ -15,6 +15,8 @@

#include <commonlib/helpers.h>
 #include <commonlib/region.h>
+#include <stddef.h>
+#include <stdlib.h>
 #include <string.h>

static inline size_t region_end(const struct region *r)
diff --git a/src/commonlib/storage/bouncebuf.c b/src/commonlib/storage/bouncebuf.c
index 5d98c74..5d727d0 100644
--- a/src/commonlib/storage/bouncebuf.c
+++ b/src/commonlib/storage/bouncebuf.c
@@ -16,10 +16,13 @@
  */

#include <arch/cache.h>
+#include <commonlib/stdlib.h>
+#include <stddef.h>
+#include <stdlib.h>
+#include <string.h>
+
 #include "bouncebuf.h"
 #include "storage.h"
-#include <string.h>
-#include <commonlib/stdlib.h>

static int addr_aligned(struct bounce_buffer *state)
 {
diff --git a/src/commonlib/storage/sdhci.c b/src/commonlib/storage/sdhci.c
index 19daa2e..b0b09fa 100644
--- a/src/commonlib/storage/sdhci.c
+++ b/src/commonlib/storage/sdhci.c
@@ -17,17 +17,20 @@
  * GNU General Public License for more details.
  */

-#include "bouncebuf.h"
 #include <commonlib/sd_mmc_ctrlr.h>
 #include <commonlib/sdhci.h>
 #include <commonlib/storage.h>
 #include <delay.h>
 #include <endian.h>
+#include <timer.h>
+#include <commonlib/stdlib.h>
+#include <stddef.h>
+#include <stdlib.h>
+
+#include "bouncebuf.h"
 #include "sdhci.h"
 #include "sd_mmc.h"
 #include "storage.h"
-#include <timer.h>
-#include <commonlib/stdlib.h>

#define DMA_AVAILABLE	((CONFIG(SDHCI_ADMA_IN_BOOTBLOCK) && ENV_BOOTBLOCK) \
    		|| (CONFIG(SDHCI_ADMA_IN_VERSTAGE) && ENV_VERSTAGE) \
diff --git a/src/commonlib/storage/sdhci_adma.c b/src/commonlib/storage/sdhci_adma.c
index e320973..c6b705b 100644
--- a/src/commonlib/storage/sdhci_adma.c
+++ b/src/commonlib/storage/sdhci_adma.c
@@ -22,6 +22,7 @@
 #include <console/console.h>
 #include <delay.h>
 #include <endian.h>
+#include <stdlib.h>
 #include <string.h>

#include "sdhci.h"

Change in coreboot[master]: src/commonlib: Use 'include <stdlib.h>' when appropriate

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33679

to look at the new patch set (#4).

Change subject: src/commonlib: Use 'include <stdlib.h>' when appropriate
......................................................................

src/commonlib: Use 'include <stdlib.h>' when appropriate

Also:
 add some missing includes spotted by Jenkins.
 including <types.h>, is supposed to provide stdint and stddef.

Change-Id: I40595df5cccd023aea486a3515c9efaf9b74ac49
Signed-off-by: Elyes HAOUAS 
---
M src/commonlib/fsp_relocate.c
M src/commonlib/include/commonlib/mem_pool.h
M src/commonlib/mem_pool.c
M src/commonlib/region.c
M src/commonlib/storage/bouncebuf.c
M src/commonlib/storage/sdhci.c
M src/commonlib/storage/sdhci_adma.c
7 files changed, 19 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/33679/4

Change in coreboot[master]: src/commonlib: Use 'include <stdlib.h>' when appropriate

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33679

to look at the new patch set (#5).

Change subject: src/commonlib: Use 'include <stdlib.h>' when appropriate
......................................................................

src/commonlib: Use 'include <stdlib.h>' when appropriate

Also:
 add some missing includes spotted by Jenkins.
 including <types.h>, is supposed to provide stdint and stddef.

Change-Id: I40595df5cccd023aea486a3515c9efaf9b74ac49
Signed-off-by: Elyes HAOUAS 
---
M src/commonlib/fsp_relocate.c
M src/commonlib/include/commonlib/mem_pool.h
M src/commonlib/mem_pool.c
M src/commonlib/region.c
M src/commonlib/storage/bouncebuf.c
M src/commonlib/storage/sdhci.c
M src/commonlib/storage/sdhci_adma.c
7 files changed, 18 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/33679/5

Change in coreboot[master]: src/commonlib: Use 'include <stdlib.h>' when appropriate

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33679

to look at the new patch set (#6).

Change subject: src/commonlib: Use 'include <stdlib.h>' when appropriate
......................................................................

src/commonlib: Use 'include <stdlib.h>' when appropriate

Also:
 add some missing includes spotted by Jenkins.
 including <types.h>, is supposed to provide stdint and stddef.

Change-Id: I40595df5cccd023aea486a3515c9efaf9b74ac49
Signed-off-by: Elyes HAOUAS 
---
M src/commonlib/fsp_relocate.c
M src/commonlib/include/commonlib/mem_pool.h
M src/commonlib/mem_pool.c
M src/commonlib/region.c
M src/commonlib/storage/bouncebuf.c
M src/commonlib/storage/sdhci.c
M src/commonlib/storage/sdhci_adma.c
7 files changed, 20 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/33679/6

Change in coreboot[master]: src/commonlib: Add some missing includes

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33679

to look at the new patch set (#7).

Change subject: src/commonlib: Add some missing includes
......................................................................

src/commonlib: Add some missing includes

Also including <types.h>, is supposed to provide stdint and stddef.

Change-Id: I40595df5cccd023aea486a3515c9efaf9b74ac49
Signed-off-by: Elyes HAOUAS 
---
M src/commonlib/fsp_relocate.c
M src/commonlib/include/commonlib/mem_pool.h
M src/commonlib/mem_pool.c
M src/commonlib/region.c
M src/commonlib/storage/bouncebuf.c
M src/commonlib/storage/sdhci.c
M src/commonlib/storage/sdhci_adma.c
7 files changed, 20 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/33679/7

Change in coreboot[master]: src/commonlib: Add some missing includes

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33679

to look at the new patch set (#8).

Change subject: src/commonlib: Add some missing includes
......................................................................

src/commonlib: Add some missing includes

Also including <types.h>, is supposed to provide stdint and stddef.

Change-Id: I40595df5cccd023aea486a3515c9efaf9b74ac49
Signed-off-by: Elyes HAOUAS 
---
M src/commonlib/fsp_relocate.c
M src/commonlib/mem_pool.c
M src/commonlib/region.c
M src/commonlib/storage/bouncebuf.c
M src/commonlib/storage/sdhci.c
M src/commonlib/storage/sdhci_adma.c
6 files changed, 18 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/33679/8

Change in coreboot[master]: src/commonlib: Add some missing includes

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33679

to look at the new patch set (#9).

Change subject: src/commonlib: Add some missing includes
......................................................................

src/commonlib: Add some missing includes

Also including <types.h>, is supposed to provide stdint and stddef.

Change-Id: I40595df5cccd023aea486a3515c9efaf9b74ac49
Signed-off-by: Elyes HAOUAS 
---
M src/commonlib/mem_pool.c
M src/commonlib/region.c
M src/commonlib/storage/bouncebuf.c
M src/commonlib/storage/sdhci.c
M src/commonlib/storage/sdhci_adma.c
5 files changed, 17 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/33679/9

Change in coreboot[master]: src/commonlib: Add some missing includes

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33679 )

Change subject: src/commonlib: Add some missing includes
......................................................................

Abandoned

see 32023