Attention is currently required from: Arthur Heymans, Jérémy Compostella, Patrick Rudolph.
Maximilian Brune has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85789?usp=email )
Change subject: cpu/x86/64bit/mode_switch: Add workaround for FSP bug
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/cpu/x86/64bit/mode_switch.S:
https://review.coreboot.org/c/coreboot/+/85789/comment/910ecd05_99d71d66?usp... :
PS2, Line 30: push $0
: push $0
nit:
Could you use `pushq` to make it more obvious how much you push onto the stack? Since we are in both x86_32 and x86_64 in this file it would make it easier for me to see how much is being pushed at a glance.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85789?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I56367d8153aa10a9b1bcaa5ffde8ebe202e8c00c
Gerrit-Change-Number: 85789
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 03 Jan 2025 18:59:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes