Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39127 )
Change subject: soc/intel/tigerlake: Add function to dump ME firmware status information ......................................................................
Patch Set 10:
Patch Set 10:
Patch Set 10:
Patch Set 10:
Hey guys. Can we implement this in src/soc/intel/common/block/cse/cse.c instead so we have a common code base. Other we would duplicate the code base
HFSTS register is not same the across SoCs. Because of this reason we cannot avoid SoC specific macros if move the function to common code. Hence, recommendation is to make the function SoC specific
It can be done, if you can create a directory inside common cse as MEx (x= CSE version) to address your header files related deltas. Then from SoC code, you can just select which is your support ME version. In this logic, your common code can get dedicated header or registers delta from respective headers with very optimal changes.
As you know, so far no SOC specific macros/ME Version specific code in CSE's common code and the amount of duplicated code is very less for now. So, going forward, if we see redundant code come with different ME versions, then we can introduce your idea to push the code to common. I would say let the code stay in SoC specific for now.