Change in coreboot[master]: sb/intel/i82801gx: Don't program CIR3

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36218 )

Change subject: sb/intel/i82801gx: Don't program CIR3
......................................................................

sb/intel/i82801gx: Don't program CIR3

X4x likely does not properly init the DMI Virtual Channels, causing
problems to this reg.

Change-Id: Ic2deeabc96c2097f3ded80d262af21d2009ce063
Signed-off-by: Arthur Heymans 
---
M src/southbridge/intel/i82801gx/early_cir.c
1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/36218/1

diff --git a/src/southbridge/intel/i82801gx/early_cir.c b/src/southbridge/intel/i82801gx/early_cir.c
index 29791bb..8efbbd1 100644
--- a/src/southbridge/intel/i82801gx/early_cir.c
+++ b/src/southbridge/intel/i82801gx/early_cir.c
@@ -30,7 +30,10 @@
    RCBA32(CG) = 1;

RCBA32(0x0088) = 0x0011d000;
-	RCBA16(0x01fc) = 0x060f;
+	/* CIR3, Private virtual channel routing, skip on x4x because of
+	   issues. (likely needs to properly set up DMI virtual channel. */
+	if (!CONFIG(NORTHBRIDGE_INTEL_X4X))
+		RCBA16(0x01fc) = 0x060f;
    RCBA32(0x01f4) = 0x86000040;
    /* Although bit 6 is set, it is not read back */
    RCBA32(0x0214) = 0x10030549;

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36218 )

Change subject: sb/intel/i82801gx: Don't program CIR3
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36218/1/src/southbridge/intel/i8280... 
File src/southbridge/intel/i82801gx/early_cir.c:

https://review.coreboot.org/c/coreboot/+/36218/1/src/southbridge/intel/i8280... 
PS1, Line 34: 	   issues. (likely needs to properly set up DMI virtual channel. */
Tag it with FIXME?

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36218 )

Change subject: sb/intel/i82801gx: Don't program CIR3
......................................................................

Patch Set 1:

… and add TEST= line?

Change in coreboot[master]: sb/intel/x4x: Don't program CIR3 on ICH7

[Arthur Heymans (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36218

to look at the new patch set (#2).

Change subject: sb/intel/x4x: Don't program CIR3 on ICH7
......................................................................

sb/intel/x4x: Don't program CIR3 on ICH7

This fixes a regression caused by 2437fe9 'sb/intel/i82801gx: Move CIR
init to a common place' on G41 boards.

G41 likely does not properly init the DMI Virtual Channels, causing
problems to this reg.

TODO: Vendor firmware on all g41 register dumps I have does not set up
VC1 on the ICH/RCBA side, which is very likely related to this. With
the vendor firmware on ICH10 variants VC1 is enabled however but
setting CIR3 equally causes  problems here. This requires
investigation, but this will fix a regression for now.

Change-Id: Ic2deeabc96c2097f3ded80d262af21d2009ce063
Signed-off-by: Arthur Heymans 
---
M src/southbridge/intel/i82801gx/early_cir.c
1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/36218/2

Change in coreboot[master]: sb/intel/x4x: Don't program CIR3 on ICH7

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36218 )

Change subject: sb/intel/x4x: Don't program CIR3 on ICH7
......................................................................

Patch Set 2: Code-Review+1

Change in coreboot[master]: sb/intel/x4x: Don't program CIR3 on ICH7

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36218 )

Change subject: sb/intel/x4x: Don't program CIR3 on ICH7
......................................................................

Patch Set 2: Code-Review-1

It does not seem enough. Not running the CIR init at all works.

Change in coreboot[master]: sb/intel/x4x: Don't program CIR3 on ICH7

[Arthur Heymans (Code Review)]

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/36218 )

Change subject: sb/intel/x4x: Don't program CIR3 on ICH7
......................................................................

Abandoned

Not working.