Change in coreboot[master]: superio/ite/it8772f/acpi: Convert superio.asl to ASL 2.0 syntax
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45991 )
Change subject: superio/ite/it8772f/acpi: Convert superio.asl to ASL 2.0 syntax ......................................................................
superio/ite/it8772f/acpi: Convert superio.asl to ASL 2.0 syntax
Change-Id: I9a4d7ddd39800f07300d3b22b02924b696917f28 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/ite/it8772f/acpi/superio.asl 1 file changed, 13 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/45991/1
diff --git a/src/superio/ite/it8772f/acpi/superio.asl b/src/superio/ite/it8772f/acpi/superio.asl index b42e71e..5132df0 100644 --- a/src/superio/ite/it8772f/acpi/superio.asl +++ b/src/superio/ite/it8772f/acpi/superio.asl @@ -39,33 +39,33 @@
Method (ENTR, 0, NotSerialized) { - Store (0x87, SI2E) - Store (0x01, SI2E) - Store (0x55, SI2E) - Store (0x55, SI2E) + SI2E = 0x87 + SI2E = 0x01 + SI2E = 0x55 + SI2E = 0x55 }
Method (EXIT, 0, NotSerialized) { - Store (0x02, SCNT) + SCNT = 0x02 }
/* Parse activate register for an LDN */ Method (ISEN, 1, NotSerialized) { ENTR () - Store (Arg0, SLDN) - Store (SACT, Local0) + SLDN = Arg0 + Local0 = SACT EXIT ()
/* Check if it exists */ - If (LEqual (Local0, 0xFF)) + If (Local0 == 0xFF) { Return (0x00) }
/* Check if activated */ - If (LEqual (Local0, One)) + If (Local0 == 1) { Return (0x0F) } @@ -79,8 +79,8 @@ Method (SENA, 1, NotSerialized) { ENTR () - Store (Arg0, SLDN) - Store (One, SACT) + SLDN = Arg0 + SACT = 1 EXIT () }
@@ -88,8 +88,8 @@ Method (SDIS, 1, NotSerialized) { ENTR () - Store (Arg0, SLDN) - Store (Zero, SACT) + SLDN = Arg0 + SACT = 0 EXIT () }
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45991 )
Change subject: superio/ite/it8772f/acpi: Convert superio.asl to ASL 2.0 syntax ......................................................................
Patch Set 1:
Any verification done?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45991 )
Change subject: superio/ite/it8772f/acpi: Convert superio.asl to ASL 2.0 syntax ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45991 )
Change subject: superio/ite/it8772f/acpi: Convert superio.asl to ASL 2.0 syntax ......................................................................
superio/ite/it8772f/acpi: Convert superio.asl to ASL 2.0 syntax
Change-Id: I9a4d7ddd39800f07300d3b22b02924b696917f28 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/45991 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/superio/ite/it8772f/acpi/superio.asl 1 file changed, 13 insertions(+), 13 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/superio/ite/it8772f/acpi/superio.asl b/src/superio/ite/it8772f/acpi/superio.asl index b42e71e..5132df0 100644 --- a/src/superio/ite/it8772f/acpi/superio.asl +++ b/src/superio/ite/it8772f/acpi/superio.asl @@ -39,33 +39,33 @@
Method (ENTR, 0, NotSerialized) { - Store (0x87, SI2E) - Store (0x01, SI2E) - Store (0x55, SI2E) - Store (0x55, SI2E) + SI2E = 0x87 + SI2E = 0x01 + SI2E = 0x55 + SI2E = 0x55 }
Method (EXIT, 0, NotSerialized) { - Store (0x02, SCNT) + SCNT = 0x02 }
/* Parse activate register for an LDN */ Method (ISEN, 1, NotSerialized) { ENTR () - Store (Arg0, SLDN) - Store (SACT, Local0) + SLDN = Arg0 + Local0 = SACT EXIT ()
/* Check if it exists */ - If (LEqual (Local0, 0xFF)) + If (Local0 == 0xFF) { Return (0x00) }
/* Check if activated */ - If (LEqual (Local0, One)) + If (Local0 == 1) { Return (0x0F) } @@ -79,8 +79,8 @@ Method (SENA, 1, NotSerialized) { ENTR () - Store (Arg0, SLDN) - Store (One, SACT) + SLDN = Arg0 + SACT = 1 EXIT () }
@@ -88,8 +88,8 @@ Method (SDIS, 1, NotSerialized) { ENTR () - Store (Arg0, SLDN) - Store (Zero, SACT) + SLDN = Arg0 + SACT = 0 EXIT () }
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)