Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37765 )
Change subject: soc/intel/tigerlake: Add required header files in pch.c ......................................................................
soc/intel/tigerlake: Add required header files in pch.c
Add header files to fix build issues due to missing declaration for get_pch_series and die_with_post_code functions.
Change-Id: Ie8ba4970ec1b73c1e481f54bcfbf95be87d9c442 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/soc/intel/tigerlake/bootblock/pch.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/37765/1
diff --git a/src/soc/intel/tigerlake/bootblock/pch.c b/src/soc/intel/tigerlake/bootblock/pch.c index 8599423..7a93182 100644 --- a/src/soc/intel/tigerlake/bootblock/pch.c +++ b/src/soc/intel/tigerlake/bootblock/pch.c @@ -19,6 +19,8 @@ * Chapter number: 2, 3, 4, 27, 28 */
+#include <console/console.h> +#include <console/post_codes.h> #include <device/mmio.h> #include <device/device.h> #include <device/pci_ops.h> @@ -30,6 +32,7 @@ #include <intelblocks/pmclib.h> #include <intelblocks/rtc.h> #include <soc/bootblock.h> +#include <soc/espi.h> #include <soc/iomap.h> #include <soc/p2sb.h> #include <soc/pch.h>
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37765 )
Change subject: soc/intel/tigerlake: Add required header files in pch.c ......................................................................
Patch Set 1: Code-Review+2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37765 )
Change subject: soc/intel/tigerlake: Add required header files in pch.c ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37765 )
Change subject: soc/intel/tigerlake: Add required header files in pch.c ......................................................................
soc/intel/tigerlake: Add required header files in pch.c
Add header files to fix build issues due to missing declaration for get_pch_series and die_with_post_code functions.
Change-Id: Ie8ba4970ec1b73c1e481f54bcfbf95be87d9c442 Signed-off-by: Aamir Bohra aamir.bohra@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37765 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/soc/intel/tigerlake/bootblock/pch.c 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Maulik V Vaghela: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/soc/intel/tigerlake/bootblock/pch.c b/src/soc/intel/tigerlake/bootblock/pch.c index 8599423..7a93182 100644 --- a/src/soc/intel/tigerlake/bootblock/pch.c +++ b/src/soc/intel/tigerlake/bootblock/pch.c @@ -19,6 +19,8 @@ * Chapter number: 2, 3, 4, 27, 28 */
+#include <console/console.h> +#include <console/post_codes.h> #include <device/mmio.h> #include <device/device.h> #include <device/pci_ops.h> @@ -30,6 +32,7 @@ #include <intelblocks/pmclib.h> #include <intelblocks/rtc.h> #include <soc/bootblock.h> +#include <soc/espi.h> #include <soc/iomap.h> #include <soc/p2sb.h> #include <soc/pch.h>
-
Aamir Bohra (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Maulik V Vaghela (Code Review)
-
Patrick Georgi (Code Review)