Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42624 )
Change subject: nb/intel/broadwell/northbridge.c: Fix typo ......................................................................
nb/intel/broadwell/northbridge.c: Fix typo
The northbridge does not have any `TESGMB`, but it has a `TSEGMB`.
Change-Id: Id25030aa86f2312e261eceb8b78c3878e9e0ee04 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/broadwell/northbridge.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/42624/1
diff --git a/src/northbridge/intel/broadwell/northbridge.c b/src/northbridge/intel/broadwell/northbridge.c index dab541a..480c17a 100644 --- a/src/northbridge/intel/broadwell/northbridge.c +++ b/src/northbridge/intel/broadwell/northbridge.c @@ -216,7 +216,7 @@ [TOLUD_REG] = MAP_ENTRY_BASE_32(TOLUD, "TOLUD"), [BDSM_REG] = MAP_ENTRY_BASE_32(BDSM, "BDSM"), [BGSM_REG] = MAP_ENTRY_BASE_32(BGSM, "BGSM"), - [TSEG_REG] = MAP_ENTRY_BASE_32(TSEG, "TESGMB"), /* FIXME: typo */ + [TSEG_REG] = MAP_ENTRY_BASE_32(TSEG, "TSEGMB"), };
static void mc_read_map_entries(struct device *dev, uint64_t *values)
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42624
to look at the new patch set (#3).
Change subject: soc/intel/broadwell/systemagent.c: Fix typo ......................................................................
soc/intel/broadwell/systemagent.c: Fix typo
Broadwell does not have any `TESGMB`, but it has a `TSEGMB`.
Change-Id: Id25030aa86f2312e261eceb8b78c3878e9e0ee04 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/systemagent.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/42624/3
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42624 )
Change subject: soc/intel/broadwell/systemagent.c: Fix typo ......................................................................
Patch Set 3: Code-Review+2
Angel Pons has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/42624 )
Change subject: soc/intel/broadwell/systemagent.c: Fix typo ......................................................................
Removed Verified+1 by build bot (Jenkins) no-reply@coreboot.org
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42624 )
Change subject: soc/intel/broadwell/systemagent.c: Fix typo ......................................................................
soc/intel/broadwell/systemagent.c: Fix typo
Broadwell does not have any `TESGMB`, but it has a `TSEGMB`.
Change-Id: Id25030aa86f2312e261eceb8b78c3878e9e0ee04 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42624 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/soc/intel/broadwell/systemagent.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/soc/intel/broadwell/systemagent.c b/src/soc/intel/broadwell/systemagent.c index b75c4fe..91816be 100644 --- a/src/soc/intel/broadwell/systemagent.c +++ b/src/soc/intel/broadwell/systemagent.c @@ -250,7 +250,7 @@ [TOLUD_REG] = MAP_ENTRY_BASE_32(TOLUD, "TOLUD"), [BDSM_REG] = MAP_ENTRY_BASE_32(BDSM, "BDSM"), [BGSM_REG] = MAP_ENTRY_BASE_32(BGSM, "BGSM"), - [TSEG_REG] = MAP_ENTRY_BASE_32(TSEG, "TESGMB"), + [TSEG_REG] = MAP_ENTRY_BASE_32(TSEG, "TSEGMB"), };
static void mc_read_map_entries(struct device *dev, uint64_t *values)
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)