Attention is currently required from: Paul Menzel.
Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79295?usp=email )
Change subject: mb/google/brox: Update storage settings for SSD and UFS ......................................................................
Patch Set 4:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79295/comment/b8bf230f_35e98e24 : PS3, Line 10: configured
configure
Done.
https://review.coreboot.org/c/coreboot/+/79295/comment/bd3a6867_bf85039d : PS3, Line 11: settings.
… according to schematic <file name>.
Done.
https://review.coreboot.org/c/coreboot/+/79295/comment/6fcedb0a_fc82e339 : PS3, Line 16: unexpect
unexpected
Done.
https://review.coreboot.org/c/coreboot/+/79295/comment/75907a2f_93b51b5b : PS3, Line 20: TEST=emerge-brox coreboot
Don’t you have access yet?
emerge-brox coreboot to make sure no build error.
File src/mainboard/google/brox/Kconfig:
https://review.coreboot.org/c/coreboot/+/79295/comment/5ee02632_c0e179b7 : PS3, Line 50: select DRIVERS_INTEL_ISH
Maybe make that a separate commit.
This is required for enabling UFS.