Change in coreboot[master]: mb/google/hatch/variants/helios: Modify DPTF parameters - coreboot-gerrit

4 Oct 2019


      Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35794 )
Change subject: mb/google/hatch/variants/helios: Modify DPTF parameters
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35794/2/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/35794/2/src/mainboard/google/hatch/... 
PS2, Line 16: #define DPTF_CPU_PASSIVE	0
Just curious, why do we set DPTF_CPU_PASSIVE, DPTF_TSR1_PASSIVE, and DPTF_TSR2_PASSIVE 0? It seems low to me.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/35794
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e5c079856a167b1c2ef52e446d055404e565858
Gerrit-Change-Number: 35794
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Philip Chen philipchen@google.com
Gerrit-Reviewer: Rajat Jain rajatja@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-CC: Frank Chu frank_chu@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Oct 2019 18:30:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment