Attention is currently required from: Bora Guvendik, Jérémy Compostella, Selma Bensaid, Nick Vaccaro.
Zhixing Ma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67913 )
Change subject: soc/intel/alderlake: Fix unknown values in SMBIOS ......................................................................
Patch Set 4:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67913/comment/9e841765_6509fa5f PS3, Line 9: smbios
s/smbios/SMBIOS/
Done
https://review.coreboot.org/c/coreboot/+/67913/comment/9f835bfe_b51a8a5d PS3, Line 9: alderlake
s/alderlake/Alder Lake/
Done
https://review.coreboot.org/c/coreboot/+/67913/comment/f5c594a2_10a2de75 PS3, Line 10: soc
s/soc/SoC/
Done
https://review.coreboot.org/c/coreboot/+/67913/comment/78ba149b_689805a4 PS3, Line 10: raptorlake
s/raptorlake/Raptor Lake/
Done
https://review.coreboot.org/c/coreboot/+/67913/comment/c999685c_94de2347 PS3, Line 14:
Aren't you missing the BUG, BRANCH and TEST tags ?
Done
Patchset:
PS3:
I think it would be better to split this patch into 3. voltage, max speed, […]
Agreed, i will split this patch.
-
Zhixing Ma (Code Review)