Change in ...coreboot[master]: src/mainboard/asus/am1i-a: Disable SeaBIOS options not supported by h...

[Mike Banon (Code Review)]

Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33869

Change subject: src/mainboard/asus/am1i-a: Disable SeaBIOS options not supported by hardware
......................................................................

src/mainboard/asus/am1i-a: Disable SeaBIOS options not supported by hardware

AM1I-A does not have any SAS or NVMe controllers, so it makes sense
to disable the related SeaBIOS options for this motherboard.
This reduces the size of compiled SeaBIOS by 129344-124096 = 5248 bytes.

Signed-off-by: Mike Banon 
Change-Id: I3f161c4ade56670fb7195a2c3f1d32e3288fba00
---
A src/mainboard/asus/am1i-a/config_seabios
1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/33869/1

diff --git a/src/mainboard/asus/am1i-a/config_seabios b/src/mainboard/asus/am1i-a/config_seabios
new file mode 100644
index 0000000..95cddb5
--- /dev/null
+++ b/src/mainboard/asus/am1i-a/config_seabios
@@ -0,0 +1,5 @@
+###
+### SeaBIOS custom configuration for ASUS AM1I-A
+###
+# CONFIG_MEGASAS is not set
+# CONFIG_NVME is not set

[Mike Banon (Code Review)]

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33869 )

Change subject: src/mainboard/asus/am1i-a: Disable SeaBIOS options not supported by hardware
......................................................................

Patch Set 1:

Similar to CB:31357, except that in this case "CONFIG_TCGBIOS" is not disabled (because unlike G505S this board has a TPM) so a size reduction is about 4x times smaller. Still it would be nice to get these patches merged.

[Mike Banon (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33869

to look at the new patch set (#2).

Change subject: src/mainboard/asus/am1i-a: Disable SeaBIOS options not supported by hardware
......................................................................

src/mainboard/asus/am1i-a: Disable SeaBIOS options not supported by hardware

AM1I-A does not have any SAS or NVMe controllers, so it makes sense
to disable the related SeaBIOS options for this motherboard.
This reduces the size of compiled SeaBIOS by 129344-124096 = 5248 bytes.

Signed-off-by: Mike Banon 
Change-Id: I3f161c4ade56670fb7195a2c3f1d32e3288fba00
---
M src/mainboard/asus/am1i-a/Kconfig
A src/mainboard/asus/am1i-a/config_seabios
2 files changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/33869/2

[Mike Banon (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33869

to look at the new patch set (#3).

Change subject: src/mainboard/asus/am1i-a: Disable SeaBIOS options not supported by hardware
......................................................................

src/mainboard/asus/am1i-a: Disable SeaBIOS options not supported by hardware

AM1I-A does not have any SAS or NVMe controllers, so it makes sense
to disable the related SeaBIOS options for this motherboard.
This reduces the size of compiled SeaBIOS by 129344-124096 = 5248 bytes.

Signed-off-by: Mike Banon 
Change-Id: I3f161c4ade56670fb7195a2c3f1d32e3288fba00
---
M src/mainboard/asus/am1i-a/Kconfig
A src/mainboard/asus/am1i-a/config_seabios
2 files changed, 10 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/33869/3

[Mike Banon (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33869

to look at the new patch set (#4).

Change subject: src/mainboard/asus/am1i-a: Disable SeaBIOS options not supported by hardware
......................................................................

src/mainboard/asus/am1i-a: Disable SeaBIOS options not supported by hardware

AM1I-A does not have any SAS or NVMe controllers, so it makes sense
to disable the related SeaBIOS options for this motherboard.
This reduces the size of compiled SeaBIOS by 129344-124096 = 5248 bytes.

Signed-off-by: Mike Banon 
Change-Id: I3f161c4ade56670fb7195a2c3f1d32e3288fba00
---
M src/mainboard/asus/am1i-a/Kconfig
A src/mainboard/asus/am1i-a/config_seabios
2 files changed, 10 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/33869/4

[Mike Banon (Code Review)]

Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33869 )

Change subject: src/mainboard/asus/am1i-a: Disable SeaBIOS options not supported by hardware
......................................................................

Abandoned

Too many revisions, need a fresh start.