Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86400?usp=email )
Change subject: drivers/usb/acpi: Account for GPIO polarity ......................................................................
Patch Set 8:
(1 comment)
File src/drivers/usb/acpi/chip.h:
https://review.coreboot.org/c/coreboot/+/86400/comment/f6389647_8b4723cc?usp... : PS7, Line 95: void acpi_device_intel_bt_common(const struct acpi_gpio *reset_gpio, : const struct acpi_gpio *enable_gpio);
https://review.coreboot.org/c/coreboot/+/86400/7/src/drivers/usb/acpi/intel_.... […]
can you be more specific? the function params are changed from int to struct acpi_gpio, and the functions to which the reset/enable params are passed are changed to ones which take the structs as params.
-
Matt DeVillier (Code Review)