Attention is currently required from: Utkarsh Verma.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74128 )
Change subject: src/arc/x86/smbios.c: Fix coverity issues ......................................................................
Patch Set 1:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74128/comment/523d2b4d_8d8cd0b2 PS1, Line 7: Fix coverity issues Please make the commit message summary/title about the action/code change. Reading `git log --oneline` this summary is not so useful, and people need to look at the full commit message.
https://review.coreboot.org/c/coreboot/+/74128/comment/79041aba_fb6bc7f3 PS1, Line 7: src/arc/x86/smbios.c: Fix coverity issues The prefix does not need to (and should not) be the path. Please use: *arch/x86/smbios*.
https://review.coreboot.org/c/coreboot/+/74128/comment/28a9ef23_93ef900b PS1, Line 12: Closes #431 Please look through `git log --grep Found-by` how to reference Coverity issues.
Patchset:
PS1: Welcome to coreboot! Working on Coverity issues is much appreciated. Some minor formal nits from my side. (If possible, please do not mix format changes with code changes.)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/74128/comment/d2fbf884_ce21c3da PS1, Line 22: : #define update_max(len, max_len, stmt) \ : do { \ : int tmp = stmt; \ : max_len = MAX(max_len, tmp); \ : len += tmp; \ Separate unrelated change?
-
Paul Menzel (Code Review)