Attention is currently required from: Nico Huber, Damien Zammit, Arthur Heymans, Alexander Couzens, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50036 )
Change subject: intel: Turn `DEFAULT_RCBA` into a Kconfig symbol
......................................................................
Patch Set 4:
(1 comment)
File src/southbridge/intel/lynxpoint/lpc.c:
https://review.coreboot.org/c/coreboot/+/50036/comment/f09afb1e_db2b61a2
PS4, Line 560: if (CONFIG_FIXED_RCBA_MMIO_BASE < default_decode_base) {
Comparisons should place the constant on the right side of the test
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50036
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I642958fbd6f02dbf54812d6a75d6bc3087acc77a
Gerrit-Change-Number: 50036
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 30 Jan 2021 23:11:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment