Attention is currently required from: Kyösti Mälkki. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63480 )
Change subject: cpu/x86/smm_module_loader: Drop superfluous checks ......................................................................
Patch Set 21:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63480/comment/54122338_61aab7b2 PS20, Line 10: parts of the code.
No need to describe it in commit message, but if you could add a gerrit review comments inline where the checks are now, please.
It's done in the code that sets up everything (l430 in this CL).
File src/cpu/x86/smm/smm_module_loader.c:
https://review.coreboot.org/c/coreboot/+/63480/comment/07236b6b_2113bb8f PS20, Line 174: * output: return -1, if runtime smi code could not be installed. In
previosly 0 or 1 was returned
Done
https://review.coreboot.org/c/coreboot/+/63480/comment/a5241be4_5f4a94ab PS20, Line 180: static int smm_place_entry_code(const unsigned int num_cpus)
always returns 1 now
Done
https://review.coreboot.org/c/coreboot/+/63480/comment/2c3cab49_8ba77e80 PS20, Line 225: static int smm_stub_place_staggered_entry_points(const struct smm_loader_params *params)
always returns 1 now ?
Done
https://review.coreboot.org/c/coreboot/+/63480/comment/1b554d8b_dcbaba0c PS20, Line 298: printk(BIOS_ERR, "%s: staggered entry points failed\n", __func__);
cannot hit this error?
Done
-
Arthur Heymans (Code Review)