Attention is currently required from: Julius Werner, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78888?usp=email )
Change subject: libpayload/libc/time: Fix possible overflow in multiplication
......................................................................
Patch Set 2:
(1 comment)
File payloads/libpayload/libc/time.c:
https://review.coreboot.org/c/coreboot/+/78888/comment/5476a0b6_2c6d394d :
PS2, Line 37: #include <libpayload-config.h>
libpayload-config.h (which defines all the `CONFIG_LP_*` constants) is better included before other headers.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78888?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia55532490651fcf47128b83a8554751f050bcc89
Gerrit-Change-Number: 78888
Gerrit-PatchSet: 2
Gerrit-Owner: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Thu, 02 Nov 2023 08:27:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment