Name of user not set #1002476 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35098 )
Change subject: util/crosgcc/patches: facilitate successful build of ipxe ......................................................................
util/crosgcc/patches: facilitate successful build of ipxe
New changes in the latest binutils(2.32) leads to assembler errors causes ipxe build failure. IPXE uses the divide test which requires /dev/null as input as well as the output file name. This patch facilitates the /dev/null as an exception to the current changes in binutils package while building crossgcc for coreboot leads to successful build of ipxe and further tests to pass based on /dev/null and applies automatically during the crossgcc rebuild.
Also this can be reverted once binutils/ipxe provides update release in this respect.
Change-Id: I9f664829b8c42420c0b2ab1f2316150f86ac0b1a Signed-off-by: Himanshu Sahdev himanshusah@hcl.com --- A util/crossgcc/patches/binutils-2.32_as-ipxe.patch 1 file changed, 35 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/35098/1
diff --git a/util/crossgcc/patches/binutils-2.32_as-ipxe.patch b/util/crossgcc/patches/binutils-2.32_as-ipxe.patch new file mode 100644 index 0000000..ab5b9b2 --- /dev/null +++ b/util/crossgcc/patches/binutils-2.32_as-ipxe.patch @@ -0,0 +1,35 @@ +From 6984bd861cc595e56d26ea033851d9174e855129 Mon Sep 17 00:00:00 2001 +From: CunningLearner sahdev.himan@gmail.com +Date: Mon, 26 Aug 2019 16:57:13 +0530 +Subject: [PATCH] as: facilitate tests based on /dev/null Signed-off-by: + Himanshu Sahdev himanshusah@hcl.com + +--- + gas/as.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/gas/as.c b/gas/as.c +index 728811bc..78b4802c 100644 +--- a/gas/as.c ++++ b/gas/as.c +@@ -1203,7 +1203,7 @@ main (int argc, char ** argv) + { + char ** argv_orig = argv; + struct stat sob; +- ++ const char *dev_null_file="/dev/null"; + int macro_strip_at; + + start_time = get_run_time (); +@@ -1252,7 +1252,7 @@ main (int argc, char ** argv) + so that switches like --hash-size can be honored. */ + parse_args (&argc, &argv); + +- if (argc > 1 && stat (out_file_name, &sob) == 0) ++ if (argc > 1 && stat (out_file_name, &sob) == 0 && strcmp(out_file_name,dev_null_file)!=0) + { + int i; + +-- +2.17.1 +
Name of user not set #1002476 has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/35098 )
Change subject: util/crossgcc/patches: facilitate successful build of ipxe ......................................................................
util/crossgcc/patches: facilitate successful build of ipxe
New changes in the latest binutils(2.32) leads to assembler errors causes ipxe build failure. IPXE uses the divide test which requires /dev/null as input as well as the output file name. This patch facilitates the /dev/null as an exception to the current changes in binutils package while building crossgcc for coreboot leads to successful build of ipxe and further tests to pass based on /dev/null and applies automatically during the crossgcc rebuild.
Also this can be reverted once binutils/ipxe provides update release in this respect.
Change-Id: I9f664829b8c42420c0b2ab1f2316150f86ac0b1a Signed-off-by: Himanshu Sahdev himanshusah@hcl.com --- A util/crossgcc/patches/binutils-2.32_as-ipxe.patch 1 file changed, 35 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/35098/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35098
to look at the new patch set (#4).
Change subject: util/crossgcc/patches: facilitate successful build of ipxe ......................................................................
util/crossgcc/patches: facilitate successful build of ipxe
New changes in the latest binutils(2.32) leads to assembler errors causes ipxe build failure. IPXE uses the divide test which requires /dev/null as input as well as the output file name.
This patch facilitates the /dev/null as an exception to the current changes in binutils package while building crossgcc for coreboot leads to successful build of ipxe and further tests to pass based on /dev/null and applies automatically during the crossgcc rebuild.
Also, this can be reverted once binutils/ipxe provides update release in this respect.
Change-Id: I9f664829b8c42420c0b2ab1f2316150f86ac0b1a Signed-off-by: Himanshu Sahdev himanshusah@hcl.com --- A util/crossgcc/patches/binutils-2.32_as-ipxe.patch 1 file changed, 35 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/35098/4
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35098 )
Change subject: util/crossgcc/patches: facilitate successful build of ipxe ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35098/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35098/4//COMMIT_MSG@9 PS4, Line 9: New changes in the latest binutils(2.32) leads to assembler errors causes No (): binutils 2.32
https://review.coreboot.org/c/coreboot/+/35098/4/util/crossgcc/patches/binut... File util/crossgcc/patches/binutils-2.32_as-ipxe.patch:
https://review.coreboot.org/c/coreboot/+/35098/4/util/crossgcc/patches/binut... PS4, Line 2: CunningLearner Space after Cunning?
https://review.coreboot.org/c/coreboot/+/35098/4/util/crossgcc/patches/binut... PS4, Line 4: Subject: [PATCH] as: facilitate tests based on /dev/null Signed-off-by: Add two line breaks before the Signed-off-by line?
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35098
to look at the new patch set (#5).
Change subject: util/crossgcc/patches: facilitate successful build of ipxe ......................................................................
util/crossgcc/patches: facilitate successful build of ipxe
New changes in the latest binutils 2.32 leads to assembler errors causes ipxe build failure. IPXE uses the divide test which requires /dev/null as input as well as the output file name.
This patch facilitates the /dev/null as an exception to the current changes in binutils package while building crossgcc for coreboot leads to successful build of ipxe and further tests to pass based on /dev/null and applies automatically during the crossgcc rebuild.
Also, this can be reverted once binutils/ipxe provides update release in this respect.
Change-Id: I9f664829b8c42420c0b2ab1f2316150f86ac0b1a Signed-off-by: Himanshu Sahdev himanshusah@hcl.com --- A util/crossgcc/patches/binutils-2.32_as-ipxe.patch 1 file changed, 35 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/35098/5
Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35098 )
Change subject: util/crossgcc/patches: facilitate successful build of ipxe ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35098/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35098/4//COMMIT_MSG@9 PS4, Line 9: New changes in the latest binutils(2.32) leads to assembler errors causes
No (): binutils 2. […]
Done
https://review.coreboot.org/c/coreboot/+/35098/4/util/crossgcc/patches/binut... File util/crossgcc/patches/binutils-2.32_as-ipxe.patch:
https://review.coreboot.org/c/coreboot/+/35098/4/util/crossgcc/patches/binut... PS4, Line 2: CunningLearner
Space after Cunning?
No, its intentional. Picked up from the system's config.
https://review.coreboot.org/c/coreboot/+/35098/4/util/crossgcc/patches/binut... PS4, Line 4: Subject: [PATCH] as: facilitate tests based on /dev/null Signed-off-by:
Add two line breaks before the Signed-off-by line?
Done
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35098
to look at the new patch set (#6).
Change subject: util/crossgcc/patches: facilitate successful build of ipxe ......................................................................
util/crossgcc/patches: facilitate successful build of ipxe
New changes in the latest binutils 2.32 leads to assembler errors causes ipxe build failure. IPXE uses the divide test which requires /dev/null as input as well as the output file name.
This patch facilitates the /dev/null as an exception to the current changes in binutils package while building crossgcc for coreboot leads to successful build of ipxe and further tests to pass based on /dev/null and applies automatically during the crossgcc rebuild.
Also, this can be reverted once binutils/ipxe provides update release in this respect.
Change-Id: I9f664829b8c42420c0b2ab1f2316150f86ac0b1a Signed-off-by: Himanshu Sahdev himanshusah@hcl.com --- A util/crossgcc/patches/binutils-2.32_as-ipxe.patch 1 file changed, 36 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/35098/6
Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35098 )
Change subject: util/crossgcc/patches: facilitate successful build of ipxe ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35098/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35098/4//COMMIT_MSG@9 PS4, Line 9: New changes in the latest binutils(2.32) leads to assembler errors causes
Done
build bot gives -1. Should be reverted?
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35098 )
Change subject: util/crossgcc/patches: facilitate successful build of ipxe ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35098/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35098/4//COMMIT_MSG@9 PS4, Line 9: New changes in the latest binutils(2.32) leads to assembler errors causes
build bot gives -1. […]
No, please just re-upload. There is an unrelated problem.
``` Building LLVM v8.0.0 for host ... failed. Check 'build-LLVM/build.log'. make[2]: *** [Makefile:40: build_clang] Error 1 make[1]: *** [util/crossgcc/Makefile.inc:57: clang] Error 2 make: *** [util/crossgcc/Makefile.inc:82: jenkins-build-toolchain] Error 2 ```
Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35098 )
Change subject: util/crossgcc/patches: facilitate successful build of ipxe ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35098/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35098/4//COMMIT_MSG@9 PS4, Line 9: New changes in the latest binutils(2.32) leads to assembler errors causes
No, please just re-upload. There is an unrelated problem. […]
Again 2 more times I rebased, gives -1.
``` Building GMP v6.1.2 for host ... failed. Check 'build-GMP/build.log'. make[4]: *** [Makefile:26: build_gcc] Error 1 make[3]: *** [Makefile:51: build-i386] Error 2 make[2]: *** [Makefile:11: all_with_gdb] Error 2 make[1]: *** [util/crossgcc/Makefile.inc:51: crosstools] Error 2 make: *** [util/crossgcc/Makefile.inc:82: jenkins-build-toolchain] Error 2 ```
Why is it happening frequently!? What do you think?
Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35098 )
Change subject: util/crossgcc/patches: facilitate successful build of ipxe ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35098/4/util/crossgcc/patches/binut... File util/crossgcc/patches/binutils-2.32_as-ipxe.patch:
https://review.coreboot.org/c/coreboot/+/35098/4/util/crossgcc/patches/binut... PS4, Line 2: CunningLearner
No, its intentional. Picked up from the system's config.
Done
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35098
to look at the new patch set (#10).
Change subject: util/crossgcc/patches: facilitate successful build of ipxe ......................................................................
util/crossgcc/patches: facilitate successful build of ipxe
New changes in the latest binutils 2.32 leads to assembler errors causes ipxe build failure. IPXE uses the divide test which requires /dev/null as input as well as the output file name.
This patch facilitates the /dev/null as an exception to the current changes in binutils package while building crossgcc for coreboot leads to successful build of ipxe and further tests to pass based on /dev/null and applies automatically during the crossgcc rebuild.
Also, this can be reverted once binutils/ipxe provides update release in this respect.
Change-Id: I9f664829b8c42420c0b2ab1f2316150f86ac0b1a Signed-off-by: Himanshu Sahdev himanshusah@hcl.com --- A util/crossgcc/patches/binutils-2.32_as-ipxe.patch 1 file changed, 36 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/35098/10
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35098 )
Change subject: util/crossgcc/patches: facilitate successful build of ipxe ......................................................................
Patch Set 10: Code-Review+1
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35098 )
Change subject: util/crossgcc/patches: facilitate successful build of ipxe ......................................................................
Patch Set 10: Code-Review+1
Hello HAOUAS Elyes, Angel Pons, Jacob Garber, Paul Menzel, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35098
to look at the new patch set (#11).
Change subject: util/crossgcc/patches: facilitate successful build of ipxe ......................................................................
util/crossgcc/patches: facilitate successful build of ipxe
This commit addresses coreboot ticket #204.
New changes in the latest binutils 2.32 leads to assembler errors causes ipxe build failure. IPXE uses the divide test which requires /dev/null as input as well as the output file name.
This patch facilitates the /dev/null as an exception to the current changes in binutils package while building crossgcc for coreboot leads to successful build of ipxe and further tests to pass based on /dev/null and applies automatically during the crossgcc rebuild.
Also, this can be reverted once binutils/ipxe provides update release in this respect.
Change-Id: I9f664829b8c42420c0b2ab1f2316150f86ac0b1a Signed-off-by: Himanshu Sahdev himanshusah@hcl.com --- A util/crossgcc/patches/binutils-2.32_as-ipxe.patch 1 file changed, 36 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/35098/11
Hello Angel Pons, Jacob Garber, Stefan Reinauer, Paul Menzel, Felix Singer, build bot (Jenkins), Patrick Georgi, HAOUAS Elyes, Mike Banon, Idwer Vollering, Nico Huber, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35098
to look at the new patch set (#12).
Change subject: util/crossgcc/patches: facilitate successful build of ipxe ......................................................................
util/crossgcc/patches: facilitate successful build of ipxe
New changes in the latest binutils 2.32 leads to assembler errors causes ipxe build failure. IPXE uses the divide test which requires /dev/null as input as well as the output file name.
This patch facilitates the /dev/null as an exception to the current changes in binutils package while building crossgcc for coreboot leads to successful build of ipxe and further tests to pass based on /dev/null and applies automatically during the crossgcc rebuild.
Also, this can be reverted once binutils/ipxe provides update release in this respect.
Fixes: https://ticket.coreboot.org/issues/204
Change-Id: I9f664829b8c42420c0b2ab1f2316150f86ac0b1a Signed-off-by: Himanshu Sahdev himanshusah@hcl.com --- A util/crossgcc/patches/binutils-2.32_as-ipxe.patch 1 file changed, 36 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/35098/12
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35098 )
Change subject: util/crossgcc/patches: facilitate successful build of ipxe ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35098/12//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35098/12//COMMIT_MSG@9 PS12, Line 9: leads lead
https://review.coreboot.org/c/coreboot/+/35098/12//COMMIT_MSG@18 PS12, Line 18: update an updated
a fixed
Hello Angel Pons, Jacob Garber, Paul Menzel, Stefan Reinauer, Felix Singer, build bot (Jenkins), Patrick Georgi, HAOUAS Elyes, Mike Banon, Idwer Vollering, Nico Huber, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35098
to look at the new patch set (#13).
Change subject: util/crossgcc/patches: facilitate successful build of ipxe ......................................................................
util/crossgcc/patches: facilitate successful build of ipxe
New changes in the latest binutils 2.32 lead to assembler errors causes ipxe build failure. IPXE uses the divide test which requires /dev/null as input as well as the output file name.
This patch facilitates the /dev/null as an exception to the current changes in binutils package while building crossgcc for coreboot leads to successful build of ipxe and further tests to pass based on /dev/null and applies automatically during the crossgcc rebuild.
Also, this can be reverted once binutils/ipxe provides an updated release in this respect.
Fixes: https://ticket.coreboot.org/issues/204
Change-Id: I9f664829b8c42420c0b2ab1f2316150f86ac0b1a Signed-off-by: Himanshu Sahdev himanshusah@hcl.com --- A util/crossgcc/patches/binutils-2.32_as-ipxe.patch 1 file changed, 36 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/35098/13
Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35098 )
Change subject: util/crossgcc/patches: facilitate successful build of ipxe ......................................................................
Patch Set 13:
(2 comments)
Done!
https://review.coreboot.org/c/coreboot/+/35098/12//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35098/12//COMMIT_MSG@9 PS12, Line 9: leads
lead
Ack
https://review.coreboot.org/c/coreboot/+/35098/12//COMMIT_MSG@18 PS12, Line 18: update
an updated […]
Ack
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35098 )
Change subject: util/crossgcc/patches: facilitate successful build of ipxe ......................................................................
Patch Set 13: Code-Review+2
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35098 )
Change subject: util/crossgcc/patches: facilitate successful build of ipxe ......................................................................
util/crossgcc/patches: facilitate successful build of ipxe
New changes in the latest binutils 2.32 lead to assembler errors causes ipxe build failure. IPXE uses the divide test which requires /dev/null as input as well as the output file name.
This patch facilitates the /dev/null as an exception to the current changes in binutils package while building crossgcc for coreboot leads to successful build of ipxe and further tests to pass based on /dev/null and applies automatically during the crossgcc rebuild.
Also, this can be reverted once binutils/ipxe provides an updated release in this respect.
Fixes: https://ticket.coreboot.org/issues/204
Change-Id: I9f664829b8c42420c0b2ab1f2316150f86ac0b1a Signed-off-by: Himanshu Sahdev himanshusah@hcl.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35098 Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- A util/crossgcc/patches/binutils-2.32_as-ipxe.patch 1 file changed, 36 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve HAOUAS Elyes: Looks good to me, but someone else must approve
diff --git a/util/crossgcc/patches/binutils-2.32_as-ipxe.patch b/util/crossgcc/patches/binutils-2.32_as-ipxe.patch new file mode 100644 index 0000000..4d2c00a --- /dev/null +++ b/util/crossgcc/patches/binutils-2.32_as-ipxe.patch @@ -0,0 +1,36 @@ +From 6984bd861cc595e56d26ea033851d9174e855129 Mon Sep 17 00:00:00 2001 +From: Himanshu Sahdev aka CunningLearner sahdev.himan@gmail.com +Date: Mon, 26 Aug 2019 16:57:13 +0530 +Subject: [PATCH] as: facilitate tests based on /dev/null + +Signed-off-by: Himanshu Sahdev himanshusah@hcl.com + +--- + gas/as.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/gas/as.c b/gas/as.c +index 728811bc..78b4802c 100644 +--- a/gas/as.c ++++ b/gas/as.c +@@ -1203,7 +1203,7 @@ main (int argc, char ** argv) + { + char ** argv_orig = argv; + struct stat sob; +- ++ const char *dev_null_file="/dev/null"; + int macro_strip_at; + + start_time = get_run_time (); +@@ -1252,7 +1252,7 @@ main (int argc, char ** argv) + so that switches like --hash-size can be honored. */ + parse_args (&argc, &argv); + +- if (argc > 1 && stat (out_file_name, &sob) == 0) ++ if (argc > 1 && stat (out_file_name, &sob) == 0 && strcmp(out_file_name,dev_null_file)!=0) + { + int i; + +-- +2.17.1 +