Attention is currently required from: Nico Huber, Jonathan Zhang, David Hendricks, Rocky Phagura, Angel Pons, Arthur Heymans.
Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52518 )
Change subject: src/cpu/x86/smm: move console init to thread safe section
......................................................................
Patch Set 1:
(1 comment)
File src/cpu/x86/smm/smm_module_handler.c:
https://review.coreboot.org/c/coreboot/+/52518/comment/5f9bfb52_4f521d65
PS1, Line 149: if (cpu > CONFIG_MAX_CPUS) {
This should never happen under normal circumstances. […]
This can happen and it does happen if someone drops in a SOC with more CPUs than originally configured for. Coreboot should not hang (looping on status bits, etc) if this happens. I'm not sure how this will hide the problem. In fact, it actually helps see the debug message on the console.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52518
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e8af35d1cde78b327144b6a9da528ae7870e874
Gerrit-Change-Number: 52518
Gerrit-PatchSet: 1
Gerrit-Owner: Rocky Phagura
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Rocky Phagura
rphagura@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Rocky Phagura
rphagura@fb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 19 Apr 2021 18:39:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment