Attention is currently required from: Zheng Bao. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58554 )
Change subject: amdfwtool: feature COMBO is fully functional ......................................................................
Patch Set 4:
(7 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131256): https://review.coreboot.org/c/coreboot/+/58554/comment/41024399_08b32b65 PS4, Line 1485: amd_psp_fw_table_saved = malloc (sizeof(amd_psp_fw_table)); space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131256): https://review.coreboot.org/c/coreboot/+/58554/comment/a704c090_ff27bdef PS4, Line 1486: amd_bios_table_saved = malloc (sizeof(amd_bios_table)); space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131256): https://review.coreboot.org/c/coreboot/+/58554/comment/786437aa_0f0eaac8 PS4, Line 1637: do { suspect code indent for conditional statements (8, 8)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131256): https://review.coreboot.org/c/coreboot/+/58554/comment/1e229e1d_eaa3b5ae PS4, Line 1656: fprintf(stderr, "Configuration file %s parsing error\n", combo_config[combo_index]); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131256): https://review.coreboot.org/c/coreboot/+/58554/comment/056b5489_01b3aa9e PS4, Line 1688: if (!comboable) { suspect code indent for conditional statements (8, 8)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131256): https://review.coreboot.org/c/coreboot/+/58554/comment/872cd3e2_fde2b164 PS4, Line 1727: if (!comboable) { suspect code indent for conditional statements (16, 16)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131256): https://review.coreboot.org/c/coreboot/+/58554/comment/e07e2b35_f1048f85 PS4, Line 1749: bhd_combo_dir->entries[combo_index].lvl2_addr = BUFF_TO_RUN(ctx, biosdir); line over 96 characters