Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/19373 )
Change subject: soc/intel/skylake: Use intel/common/block/smbus code
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/#/c/19373/11/src/soc/intel/skylake/include/soc/p...
File src/soc/intel/skylake/include/soc/pm.h:
Line 54
I don't think we should just delete this. I was jut noting we should change
Ok.Renamed it to TCO_SMI_EN in PS#12.
--
To view, visit
https://review.coreboot.org/19373
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ca32ab594552424e4f1358302641f159a3d7e62
Gerrit-PatchSet: 11
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: Yes