Attention is currently required from: Eric Lai, Kapil Porwal, Matt DeVillier, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80062?usp=email )
Change subject: mb/google/brya/var/*: Ensure LCD device has a valid address
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/anahera/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/80062/comment/af4d5c38_9a75e6e3 :
PS1, Line 122: 0x80010400
the short answer is I copied it from the other Brya variants which did set it already 😊 (Also the same value used by the GMA driver for the LCD as device 0 on first port).
Long answer:
- bit 31 = use the ACPI-defined (vs vendor-defined) bit scheme for bits 15-0
- bit 16 = platform firmware can detect the device
- bit 10 = display type is internal/integrated flat panel (aka LCD)
from ACPI spec 6.5, table B-2.
can u please capture that as part of commit msg
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80062?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id24e330cfb7c993d12665a704e1ca78e2e38874f
Gerrit-Change-Number: 80062
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 18 Jan 2024 15:43:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment