Attention is currently required from: Kenneth Chan, Nick Vaccaro, Ren Kuo.
Paul Menzel has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84143?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brox/jubilant: I2C signal tuning
......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84143/comment/48179bb9_6fded4b8?usp... :
PS1, Line 7: I2C signal tuning
Please look through `git log --oneline` on how to write the summary (also for I2C tuning).
https://review.coreboot.org/c/coreboot/+/84143/comment/3485ccdc_a05c0f5c?usp... :
PS1, Line 10: HW requirement
… of ….
https://review.coreboot.org/c/coreboot/+/84143/comment/f1d1c662_d9b27fa2?usp... :
PS1, Line 10: 250ns
The diff does more than this?
https://review.coreboot.org/c/coreboot/+/84143/comment/b2adb135_62c5ae3f?usp... :
PS1, Line 14: Measure the i2c signal on jubilant to meet spec
Please include your measurements.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84143?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I42a60edc0b361bfabacf5376ef89f436efedb356
Gerrit-Change-Number: 84143
Gerrit-PatchSet: 1
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Comment-Date: Sat, 31 Aug 2024 06:00:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No