Attention is currently required from: Raul Rangel, Eric Lai, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74099 )
Change subject: mb/google/myst: Enable chromeOS EC ......................................................................
Patch Set 5:
(6 comments)
File src/mainboard/google/myst/Kconfig:
https://review.coreboot.org/c/coreboot/+/74099/comment/e67df7c7_4bbf925b PS5, Line 19: : config CHROMEOS : select EC_GOOGLE_CHROMEEC_SWITCHES
Why is this different from Skyrim, which doesn't have `config CHROMEOS`? […]
We should match Skyrim. Skyrim started this way too but it caused non-chromeos builds to fail.
https://review.coreboot.org/c/coreboot/+/74099/comment/d1d6f50a_2fb8a242 PS5, Line 29: config IGNORE_IASL_MISSING_DEPENDENCY : def_bool y
What is this? I don't see it in code search.
Didn't realize we had dropped this: https://review.coreboot.org/c/coreboot/+/63525. Updated to remove it.
File src/mainboard/google/myst/variants/baseboard/include/baseboard/ec.h:
https://review.coreboot.org/c/coreboot/+/74099/comment/0b4c2510_aaca24ec PS5, Line 26: | EC_HOST_EVENT_MASK(EC_HOST_EVENT_PANIC))
Missing: `EC_HOST_EVENT_BODY_DETECT_CHANGE`
Done
https://review.coreboot.org/c/coreboot/+/74099/comment/9904e617_673f0cf8 PS5, Line 58: #define EC_SCI_GPI GEVENT_24 /* eSPI system event -> GPE 24 */
GPE11? […]
This event is correct. Raul clarified in a previous comment
https://review.coreboot.org/c/coreboot/+/74099/comment/6a79baf0_880c34f2 PS5, Line 62: #define EC_ENABLE_WAKE_PIN GEVENT_5 /* AGPIO 11 -> GPE 5 */
`GEVENT_5` is not listed, but neither is the lid switch, unless there's some abreviation I'm missing […]
It should be GPE 13. It corresponds to EC_SOC_WAKE_L. Good catch, updated the CL.
https://review.coreboot.org/c/coreboot/+/74099/comment/97656ea0_b7384664 PS5, Line 76: #define EC_SYNC_IRQ GPIO_84
I'm not sure what the "sync" IRQ is, but GPIO 74 is `FANIN0`.
It should correspond to EC_SOC_INT_ODL. This should be GPIO90. Updated the CL.
-
Jon Murphy (Code Review)