Change in coreboot[master]: mb/facebook/monolith: Update power supply settings

[Wim Vervoorn (Code Review)]

Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38429 )

Change subject: mb/facebook/monolith: Update power supply settings
......................................................................

mb/facebook/monolith: Update power supply settings

Update the IccMax for the SYSTEM_AGENT and IA_CORE power supplies
according to the information in the schematic. The IccMax for these
supplies is lower than the standard supported by the SoC.

BUG=N/A
TEST=build

Change-Id: I20b92e7dfc85427bcf9cb9f0efda02459c862809
Signed-off-by: Wim Vervoorn 
---
M src/mainboard/facebook/monolith/devicetree.cb
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/38429/1

diff --git a/src/mainboard/facebook/monolith/devicetree.cb b/src/mainboard/facebook/monolith/devicetree.cb
index 399d9af..a5f5b54 100644
--- a/src/mainboard/facebook/monolith/devicetree.cb
+++ b/src/mainboard/facebook/monolith/devicetree.cb
@@ -89,7 +89,7 @@
    #| Psi4Enable     | 1     | 1     | 1     | 1     |
    #| ImonSlope      | 0     | 0     | 0     | 0     |
    #| ImonOffset     | 0     | 0     | 0     | 0     |
-	#| IccMax         | 7A    | 34A   | 35A   | 35A   |
+	#| IccMax         | 5.1A  | 32A   | 35A   | 35A   |
    #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V |
    #+----------------+-------+-------+-------+-------+
    register "domain_vr_config[VR_SYSTEM_AGENT]" = "{
@@ -101,7 +101,7 @@
    	.psi4enable = 1, \
    	.imon_slope = 0, \
    	.imon_offset = 0, \
-		.icc_max = VR_CFG_AMP(7), \
+		.icc_max = VR_CFG_AMP(5.1), \
    	.voltage_limit = 1520 \
    }"

@@ -114,7 +114,7 @@
    	.psi4enable = 1, \
    	.imon_slope = 0, \
    	.imon_offset = 0, \
-		.icc_max = VR_CFG_AMP(34), \
+		.icc_max = VR_CFG_AMP(32), \
    	.voltage_limit = 1520 \
    }"

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38429 )

Change subject: mb/facebook/monolith: Update power supply settings
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38429 )

Change subject: mb/facebook/monolith: Update power supply settings
......................................................................

mb/facebook/monolith: Update power supply settings

Update the IccMax for the SYSTEM_AGENT and IA_CORE power supplies
according to the information in the schematic. The IccMax for these
supplies is lower than the standard supported by the SoC.

BUG=N/A
TEST=build

Change-Id: I20b92e7dfc85427bcf9cb9f0efda02459c862809
Signed-off-by: Wim Vervoorn 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38429
Tested-by: build bot (Jenkins) 
Reviewed-by: Frans Hendriks 
---
M src/mainboard/facebook/monolith/devicetree.cb
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Frans Hendriks: Looks good to me, approved

diff --git a/src/mainboard/facebook/monolith/devicetree.cb b/src/mainboard/facebook/monolith/devicetree.cb
index 399d9af..a5f5b54 100644
--- a/src/mainboard/facebook/monolith/devicetree.cb
+++ b/src/mainboard/facebook/monolith/devicetree.cb
@@ -89,7 +89,7 @@
    #| Psi4Enable     | 1     | 1     | 1     | 1     |
    #| ImonSlope      | 0     | 0     | 0     | 0     |
    #| ImonOffset     | 0     | 0     | 0     | 0     |
-	#| IccMax         | 7A    | 34A   | 35A   | 35A   |
+	#| IccMax         | 5.1A  | 32A   | 35A   | 35A   |
    #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V |
    #+----------------+-------+-------+-------+-------+
    register "domain_vr_config[VR_SYSTEM_AGENT]" = "{
@@ -101,7 +101,7 @@
    	.psi4enable = 1, \
    	.imon_slope = 0, \
    	.imon_offset = 0, \
-		.icc_max = VR_CFG_AMP(7), \
+		.icc_max = VR_CFG_AMP(5.1), \
    	.voltage_limit = 1520 \
    }"

@@ -114,7 +114,7 @@
    	.psi4enable = 1, \
    	.imon_slope = 0, \
    	.imon_offset = 0, \
-		.icc_max = VR_CFG_AMP(34), \
+		.icc_max = VR_CFG_AMP(32), \
    	.voltage_limit = 1520 \
    }"

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38429 )

Change subject: mb/facebook/monolith: Update power supply settings
......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3
Emulation targets:
EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/151
EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/150
EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/149

Please note: This test is under development and might not be accurate at all!