Attention is currently required from: Bill XIE, Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Kyösti Mälkki, Matt DeVillier, Patrick Georgi, Paul Menzel, Werner Zeh.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78623?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: Kconfig: Decrease default HEAP_SIZE from 1 MiB to 512 KiB
......................................................................
Patch Set 10:
(2 comments)
Patchset:
PS10:
We probably don't want to reduce the sizes of the heaps that were larger than 512KB. You should probably look through the last patch for those files and pull in the changes to their Kconfigs that were removed.
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/78623/comment/14a2f45a_107e2c1e :
PS10, Line 753: hex
Looking at the state of things before the patch this is replacing, you probably want to add the line:
```
default 0x100000 if FLATTENED_DEVICE_TREE
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78623?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib1de1eb8487df5bdf004e544d40667833a291515
Gerrit-Change-Number: 78623
Gerrit-PatchSet: 10
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@9elements.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Bill XIE
persmule@hardenedlinux.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 01 Nov 2023 23:22:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment