Attention is currently required from: Nico Huber, Nick Vaccaro, Zhuohao Lee.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60129 )
Change subject: libpayload/i8042: Use 'INFO' instead of 'ERROR' when probing failed
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60129/comment/86ebfcc3_34729622
PS2, Line 13: when doing the autotest.
Hmmm, if it's critical pretty much depends on the hardware :) […]
PC_I8042 is selected by default for x86 devices (through PC_KEYBOARD) ... I guess we could explicitly unselect it for `brask` instead, but if this driver is compiled in for all x86 libpayload-based payloads, then I maybe ERROR isn't the right
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60129
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2880c854b873a2a00aa0d8b1cbb4f86fa8139255
Gerrit-Change-Number: 60129
Gerrit-PatchSet: 2
Gerrit-Owner: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
patrick@coreboot.org
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Comment-Date: Mon, 20 Dec 2021 19:26:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Gerrit-MessageType: comment