Attention is currently required from: Hung-Te Lin, Paul Menzel. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60318 )
Change subject: soc/mediatek/mt8186: Add DRAM full calibration support ......................................................................
Patch Set 8:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60318/comment/99ed97a0_e26e4be6 PS7, Line 10: We remove emi.h because emi.h is defined in common/include/soc.
Please make that a separate commit.
I think it's hard to remove this patch in separate commmit. There are some dependency for some configuration. I think it will be proper to have all these changes in one patch. Or the quantity of commits will be too much.
Patchset:
PS7:
Please also split SOC and mainboard changes into separate commits.
I think it's hard to remove this patch in separate commmit. There are some dependency for some configuration. I think it will be proper to have all these changes in one patch. Or the quantity of commits will be too much.
-
Rex-BC Chen (Code Review)