Daisuke Nojiri has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45967 )
Change subject: Fleex: Resume from suspend on critical battery ......................................................................
Fleex: Resume from suspend on critical battery
This patch makes Fleex EC wake up AP from s0ix when the state of charge drops to 5%.
Demonstrated as follows:
1. Boot Fleex. 2. Run powerd_dbus_suspend. 3. On EC, run battfake 5. 4. System resumes.
BUG=b:163721887 BRANCH=Octopus TEST=Verified on Fleex:
Signed-off-by: Daisuke Nojiri dnojiri@chromium.org Change-Id: I4a998ad0aef5a7cfc6fd18995bde5571e6127e77 --- M src/mainboard/google/octopus/variants/fleex/include/variant/ec.h 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/45967/1
diff --git a/src/mainboard/google/octopus/variants/fleex/include/variant/ec.h b/src/mainboard/google/octopus/variants/fleex/include/variant/ec.h index 60c53dc..29aee4f 100644 --- a/src/mainboard/google/octopus/variants/fleex/include/variant/ec.h +++ b/src/mainboard/google/octopus/variants/fleex/include/variant/ec.h @@ -5,4 +5,9 @@
#include <baseboard/ec.h>
+#undef MAINBOARD_EC_S0IX_WAKE_EVENTS +#define MAINBOARD_EC_S0IX_WAKE_EVENTS \ + (MAINBOARD_EC_S3_WAKE_EVENTS |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_CRITICAL)) + #endif
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45967 )
Change subject: Fleex: Resume from suspend on critical battery ......................................................................
Patch Set 1: Code-Review+2
Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45967 )
Change subject: Fleex: Resume from suspend on critical battery ......................................................................
Fleex: Resume from suspend on critical battery
This patch makes Fleex EC wake up AP from s0ix when the state of charge drops to 5%.
Demonstrated as follows:
1. Boot Fleex. 2. Run powerd_dbus_suspend. 3. On EC, run battfake 5. 4. System resumes.
BUG=b:163721887 BRANCH=Octopus TEST=Verified on Fleex:
Signed-off-by: Daisuke Nojiri dnojiri@chromium.org Change-Id: I4a998ad0aef5a7cfc6fd18995bde5571e6127e77 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45967 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com --- M src/mainboard/google/octopus/variants/fleex/include/variant/ec.h 1 file changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified EricR Lai: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/fleex/include/variant/ec.h b/src/mainboard/google/octopus/variants/fleex/include/variant/ec.h index 60c53dc..29aee4f 100644 --- a/src/mainboard/google/octopus/variants/fleex/include/variant/ec.h +++ b/src/mainboard/google/octopus/variants/fleex/include/variant/ec.h @@ -5,4 +5,9 @@
#include <baseboard/ec.h>
+#undef MAINBOARD_EC_S0IX_WAKE_EVENTS +#define MAINBOARD_EC_S0IX_WAKE_EVENTS \ + (MAINBOARD_EC_S3_WAKE_EVENTS |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_CRITICAL)) + #endif
-
Aaron Durbin (Code Review) -
Daisuke Nojiri (Code Review)
-
EricR Lai (Code Review)