Change in coreboot[master]: mb/intel/tglrvp: add Tiger Lake memory initialization support
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38998 )
Change subject: mb/intel/tglrvp: add Tiger Lake memory initialization support ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38998/4/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/38998/4/src/mainboard/intel/tglrvp/... PS4, Line 21: #include "board_id.h" nit - please move local double-quoted includes to bottom of includes list
https://review.coreboot.org/c/coreboot/+/38998/4/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/38998/4/src/mainboard/intel/tglrvp/... PS4, Line 18: += first setting of SPD_SOURCES should use "="
-
Nick Vaccaro (Code Review)