[M] Change in coreboot[main]: mb/google/brox: Hint romstage init about upcoming reset

[Subrata Banik (Code Review)]

Attention is currently required from: Bob Moragues, Karthik Ramasubramanian, Paul Menzel, Shyam Sundar Radjacoumar.

Subrata Banik has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/84937?usp=email )

Change subject: mb/google/brox: Hint romstage init about upcoming reset
......................................................................

Patch Set 5:

(2 comments)

File src/mainboard/google/brox/variants/baseboard/brox/romstage.c:

https://review.coreboot.org/c/coreboot/+/84937/comment/5aae302d_7909457f?usp... :
PS5, Line 24: 	ret = google_chromeec_get_num_pd_ports(&num_ports);
            : 	if (ret < 0 || !num_ports) {
            : 		printk(BIOS_INFO, "%s: Cannot resolve # of USB PD ports\n", __func__);
            : 		return mismatch;
            : 	}
I'm wondering if we need to call this API at all. This is mainboard-specific code and we know Brox has PD ports, so this may not be needed for mainboard code alone. Perhaps if you moved this code into SOC or a common location, then checking for the presence of PD ports would make more sense. In Brox's case, reading the PDC info looks more meaningful.

thoughts ?

https://review.coreboot.org/c/coreboot/+/84937/comment/308a5d55_386c6af2?usp... :
PS5, Line 30: google_chromeec_get_pd_chip_infoi
is this a typo ?

`_infoi` ?