Lucas Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45785 )
Change subject: zork/var/ezkinil: Adjust Touchscreen suspend off timing ......................................................................
zork/var/ezkinil: Adjust Touchscreen suspend off timing
Adjust Touchscreen delay off values to let suspend off timing match power down specificatiion.
BRANCH=zork BUG=b:163434386 TEST=Measuring scope timing
Change-Id: I58866122f441cc3c427e659b8a5fdb6643987882 --- M src/mainboard/google/zork/variants/ezkinil/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/45785/1
diff --git a/src/mainboard/google/zork/variants/ezkinil/overridetree.cb b/src/mainboard/google/zork/variants/ezkinil/overridetree.cb index 614d6ab..a60f427 100644 --- a/src/mainboard/google/zork/variants/ezkinil/overridetree.cb +++ b/src/mainboard/google/zork/variants/ezkinil/overridetree.cb @@ -86,7 +86,9 @@ register "generic.enable_delay_ms" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_140)" register "generic.reset_delay_ms" = "20" + register "generic.reset_off_delay_ms" = "5" register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_144)" + register "generic.stop_off_delay_ms" = "10" register "generic.stop_delay_ms" = "300" register "generic.has_power_resource" = "1" register "generic.disable_gpio_export_in_crs" = "1"
Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45785 )
Change subject: zork/var/ezkinil: Adjust Touchscreen suspend off timing ......................................................................
Patch Set 1: Code-Review+1
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45785 )
Change subject: zork/var/ezkinil: Adjust Touchscreen suspend off timing ......................................................................
Patch Set 1: Code-Review+1
Missing 'Signed-off-by' tag.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45785 )
Change subject: zork/var/ezkinil: Adjust Touchscreen suspend off timing ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45785/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45785/1//COMMIT_MSG@15 PS1, Line 15: No Signed-off-by line in commit message
https://review.coreboot.org/c/coreboot/+/45785/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45785/1/src/mainboard/google/zork/v... PS1, Line 66: RAYD0001 What about Raydium touchscreen device?
Hello build bot (Jenkins), David Wu, Furquan Shaikh, Bhanu Prakash Maiya, Vincent Wang, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45785
to look at the new patch set (#2).
Change subject: zork/var/ezkinil: Adjust Touchscreen suspend off timing ......................................................................
zork/var/ezkinil: Adjust Touchscreen suspend off timing
Adjust Touchscreen delay off values to let suspend off timing match power down specificatiion.
BRANCH=zork BUG=b:163434386 TEST=Measuring scope timing
Signed-off-by: Lucas Chen lucas.chen@quanta.corp-partner.google.com Change-Id: I58866122f441cc3c427e659b8a5fdb6643987882 --- M src/mainboard/google/zork/variants/ezkinil/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/45785/2
Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45785 )
Change subject: zork/var/ezkinil: Adjust Touchscreen suspend off timing ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45785/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45785/1//COMMIT_MSG@15 PS1, Line 15:
No Signed-off-by line in commit message
Done.
https://review.coreboot.org/c/coreboot/+/45785/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45785/1/src/mainboard/google/zork/v... PS1, Line 66: RAYD0001
What about Raydium touchscreen device?
Check with our PM, Ezkinil is use ELAN touchscreen only.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45785 )
Change subject: zork/var/ezkinil: Adjust Touchscreen suspend off timing ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45785/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45785/1/src/mainboard/google/zork/v... PS1, Line 66: RAYD0001
Check with our PM, Ezkinil is use ELAN touchscreen only.
In that case, can you please drop the Raydium touchscreen entry in a separate CL?
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45785 )
Change subject: zork/var/ezkinil: Adjust Touchscreen suspend off timing ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45785 )
Change subject: zork/var/ezkinil: Adjust Touchscreen suspend off timing ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45785/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45785/1/src/mainboard/google/zork/v... PS1, Line 66: RAYD0001
In that case, can you please drop the Raydium touchscreen entry in a separate CL?
Lucas - can you please drop the unused entry in a separate change? I am marking this comment as resolved to get the current change landed.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45785 )
Change subject: zork/var/ezkinil: Adjust Touchscreen suspend off timing ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45785/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45785/1//COMMIT_MSG@15 PS1, Line 15:
Done.
Done
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45785 )
Change subject: zork/var/ezkinil: Adjust Touchscreen suspend off timing ......................................................................
zork/var/ezkinil: Adjust Touchscreen suspend off timing
Adjust Touchscreen delay off values to let suspend off timing match power down specificatiion.
BRANCH=zork BUG=b:163434386 TEST=Measuring scope timing
Signed-off-by: Lucas Chen lucas.chen@quanta.corp-partner.google.com Change-Id: I58866122f441cc3c427e659b8a5fdb6643987882 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45785 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Rob Barnes robbarnes@google.com --- M src/mainboard/google/zork/variants/ezkinil/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Lucas Chen: Looks good to me, but someone else must approve Rob Barnes: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/zork/variants/ezkinil/overridetree.cb b/src/mainboard/google/zork/variants/ezkinil/overridetree.cb index 614d6ab..a60f427 100644 --- a/src/mainboard/google/zork/variants/ezkinil/overridetree.cb +++ b/src/mainboard/google/zork/variants/ezkinil/overridetree.cb @@ -86,7 +86,9 @@ register "generic.enable_delay_ms" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_140)" register "generic.reset_delay_ms" = "20" + register "generic.reset_off_delay_ms" = "5" register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_144)" + register "generic.stop_off_delay_ms" = "10" register "generic.stop_delay_ms" = "300" register "generic.has_power_resource" = "1" register "generic.disable_gpio_export_in_crs" = "1"
-
Furquan Shaikh (Code Review) -
Lucas Chen (Code Review)
-
Rob Barnes (Code Review)