Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35948 )
Change subject: nb/intel/pineview/Kconfig: Remove romcc leftover ......................................................................
nb/intel/pineview/Kconfig: Remove romcc leftover
This is unused since C_ENVIRONMENT_BOOTBLOCK is used.
Change-Id: Id5af41e455d211eba89cfeb625f4c728b4145da7 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/pineview/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/35948/1
diff --git a/src/northbridge/intel/pineview/Kconfig b/src/northbridge/intel/pineview/Kconfig index d1d776b..edf4f23 100644 --- a/src/northbridge/intel/pineview/Kconfig +++ b/src/northbridge/intel/pineview/Kconfig @@ -30,10 +30,6 @@ select PARALLEL_MP select C_ENVIRONMENT_BOOTBLOCK
-config BOOTBLOCK_NORTHBRIDGE_INIT - string - default "northbridge/intel/pineview/bootblock.c" - config VGA_BIOS_ID string default "8086,a001"
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35948 )
Change subject: nb/intel/pineview/Kconfig: Remove romcc leftover ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35948 )
Change subject: nb/intel/pineview/Kconfig: Remove romcc leftover ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35948 )
Change subject: nb/intel/pineview/Kconfig: Remove romcc leftover ......................................................................
Patch Set 1: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35948 )
Change subject: nb/intel/pineview/Kconfig: Remove romcc leftover ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35948 )
Change subject: nb/intel/pineview/Kconfig: Remove romcc leftover ......................................................................
nb/intel/pineview/Kconfig: Remove romcc leftover
This is unused since C_ENVIRONMENT_BOOTBLOCK is used.
Change-Id: Id5af41e455d211eba89cfeb625f4c728b4145da7 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/35948 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Nico Huber nico.h@gmx.de --- M src/northbridge/intel/pineview/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Patrick Rudolph: Looks good to me, approved
diff --git a/src/northbridge/intel/pineview/Kconfig b/src/northbridge/intel/pineview/Kconfig index d1d776b..edf4f23 100644 --- a/src/northbridge/intel/pineview/Kconfig +++ b/src/northbridge/intel/pineview/Kconfig @@ -30,10 +30,6 @@ select PARALLEL_MP select C_ENVIRONMENT_BOOTBLOCK
-config BOOTBLOCK_NORTHBRIDGE_INIT - string - default "northbridge/intel/pineview/bootblock.c" - config VGA_BIOS_ID string default "8086,a001"
-
Arthur Heymans (Code Review) -
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)