Attention is currently required from: Eric Lai.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69208 )
Change subject: vboot: Introduce handy vboot reboot functions
......................................................................
Patch Set 3:
(2 comments)
File src/security/vboot/vboot_common.c:
https://review.coreboot.org/c/coreboot/+/69208/comment/5a95d4d0_a1b5305b
PS1, Line 14: if (!verification_should_run() && !(ENV_ROMSTAGE && CONFIG(VBOOT_EARLY_EC_SYNC))
Is this block belong to the next patch?
Yes, it does. I did lazy split of patch and forgot about it. Thanks :)
File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/c/coreboot/+/69208/comment/d33e80ff_8b14311d
PS2, Line 354: vboot_save_data(ctx);
I think we can move this below the […]
It makes sense. vboot data will be saved in both cases only once. Thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69208
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie29410e8985e7cf19bd8d4cccc393b050ca1f1c5
Gerrit-Change-Number: 69208
Gerrit-PatchSet: 3
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Sat, 05 Nov 2022 15:30:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment