Attention is currently required from: Fred, Zheng Bao, Fred Reitberger, Felix Held.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73180 )
Change subject: amdfwtool: Clean up the logic sequence of pointer growing
......................................................................
Patch Set 3:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/73180/comment/9846af9d_b8c700b0
PS2, Line 2526: if (efs_location != body_location) {
braces {} are not necessary for any arm of this statement […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73180
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia81e2bdf9feb02971723f39e7f223b5055807cd8
Gerrit-Change-Number: 73180
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred
eldmannen@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Fred
eldmannen@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 28 Feb 2023 03:33:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-MessageType: comment