Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73233 )
Change subject: mb/google/nissa/var/xivu: Disable world-facing microphone ......................................................................
mb/google/nissa/var/xivu: Disable world-facing microphone
Remove world-facing microphone for xivu360. Switching to world-facing camera will use the user-facing microphone to record sound.
BUG=b:263927799 TEST=emerge-nissa coreboot chromeos-bootimage
Change-Id: Ibb720974b6488ce4453081e0bc5b4e7f34a6b0f6 Signed-off-by: Ian Feng ian_feng@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/73233 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Reka Norman rekanorman@chromium.org Reviewed-by: Frank Wu frank_wu@compal.corp-partner.google.com Reviewed-by: John Su john_su@compal.corp-partner.google.com Reviewed-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com --- M src/mainboard/google/brya/variants/xivu/fw_config.c M src/mainboard/google/brya/variants/xivu/gpio.c 2 files changed, 27 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Frank Wu: Looks good to me, approved John Su: Looks good to me, approved Dtrain Hsu: Looks good to me, approved Reka Norman: Looks good to me, approved
diff --git a/src/mainboard/google/brya/variants/xivu/fw_config.c b/src/mainboard/google/brya/variants/xivu/fw_config.c index 0bf0626..9008b95 100644 --- a/src/mainboard/google/brya/variants/xivu/fw_config.c +++ b/src/mainboard/google/brya/variants/xivu/fw_config.c @@ -15,10 +15,6 @@ PAD_NC_LOCK(GPP_D16, NONE, LOCK_CONFIG), /* H22 : WCAM_MCLK_R */ PAD_NC(GPP_H22, NONE), - /* R6 : DMIC_WCAM_CLK_R */ - PAD_NC(GPP_R6, NONE), - /* R7 : DMIC_WCAM_DATA */ - PAD_NC(GPP_R7, NONE), };
void fw_config_gpio_padbased_override(struct pad_config *padbased_table) diff --git a/src/mainboard/google/brya/variants/xivu/gpio.c b/src/mainboard/google/brya/variants/xivu/gpio.c index 12fb39d..8426997 100644 --- a/src/mainboard/google/brya/variants/xivu/gpio.c +++ b/src/mainboard/google/brya/variants/xivu/gpio.c @@ -25,6 +25,10 @@ PAD_NC(GPP_F4, NONE), /* F5 : CRF_XTAL_CLKREQ ==> NC */ PAD_NC(GPP_F5, NONE), + /* R6 : DMIC_CLK_A_1A ==> NC */ + PAD_NC(GPP_R6, NONE), + /* R7 : DMIC_DATA_1A ==> NC */ + PAD_NC(GPP_R7, NONE), };
/* Early pad configuration in bootblock */