Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32925 )
Change subject: mb/google/kohaku: add internal pull-up GPP_H0 for kohaku
......................................................................
Patch Set 1:
Instead of internal PU, can you check w/ OEM and see if external PU is required?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32925
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29b2392151d989da5e3a475d3da5cfde9f912bb8
Gerrit-Change-Number: 32925
Gerrit-PatchSet: 1
Gerrit-Owner: Ben Kao
ben.kao@intel.com
Gerrit-Reviewer: Ben Kao
ben.kao@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 22 May 2019 05:42:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment