Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18548 )
Change subject: nb/intel/i945: Program CxODT value for each channel
......................................................................
Patch Set 30:
Patch Set 30:
I've populated only channel 0 with 2 DIMMs
as you can see, we have the message "C1ODT: Channel 1 has one DIMM."
https://pastebin.com/9pxTYPQx
The board boots but this patch does not what expected
That might happen if the SPD mapping is incorrect. That is, your mainboard settings might be saying that the SPD on CH1-S0 is for CH0-S1
--
To view, visit
https://review.coreboot.org/c/coreboot/+/18548
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7aec35f45250da554ddc5a68f5add157c313399c
Gerrit-Change-Number: 18548
Gerrit-PatchSet: 30
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Fri, 13 Mar 2020 10:30:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment