Attention is currently required from: Andrey Petrov, Intel coreboot Reviewers, Julius Werner, Karthik Ramasubramanian, Ronak Kanabar.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86367?usp=email )
Change subject: lib: Centralize logo.bmp inclusion in lib/Makefile.mk
......................................................................
Patch Set 3:
(1 comment)
File src/lib/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/86367/comment/ec07975e_8eaea3f5?usp... :
PS3, Line 427: CONFIG_FSP2_0_LOGO_FILE_NAME
Actually, why is this an FSP2_0 option? This should probably also move to `src/lib/Kconfig` and be renamed to something not related to FSP.
it needs some refactoring due to BMP_LOGO existed inside both FSP1.1 and FSP2.0 driver. if you are insisting to do it **now**, then I don't have other options to accommodate the feedback. Otherwise, I would prefer to push a clean up patch to unify the BMP logo usage between FSPx drivers.
Thoughts ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86367?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I16ed1cf29b839c25b6ea1c2f10faf3d99dd707c9
Gerrit-Change-Number: 86367
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 12 Feb 2025 11:23:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org