Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34292 )
Change subject: device: Remove dead assignment ......................................................................
device: Remove dead assignment
last_unitid is immediately overwritten in the do loop, so this assignment is not needed. This a relic from old code that commit 13f1c2af8b made obsolete, but was never removed.
Change-Id: I2eecddd025f7a64b0a70fc07a61ebb43aba757d6 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: scan-build 8.0.0 --- M src/device/hypertransport.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/34292/1
diff --git a/src/device/hypertransport.c b/src/device/hypertransport.c index ccad5ce..027c3ef 100644 --- a/src/device/hypertransport.c +++ b/src/device/hypertransport.c @@ -291,7 +291,6 @@ prev.freq_cap_off = PCI_HT_CAP_HOST_FREQ_CAP;
/* If present, assign unitid to a hypertransport chain. */ - last_unitid = min_unitid -1; max_unitid = next_unitid = min_unitid; do { u8 pos;
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34292 )
Change subject: device: Remove dead assignment ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34292/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34292/1//COMMIT_MSG@7 PS1, Line 7: device device/hypertransport.c
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34292
to look at the new patch set (#2).
Change subject: device/hypertransport.c: Remove dead assignment ......................................................................
device/hypertransport.c: Remove dead assignment
last_unitid is immediately overwritten in the do loop, so this assignment is not needed. This a relic from old code that commit 13f1c2af8b made obsolete, but was never removed.
Change-Id: I2eecddd025f7a64b0a70fc07a61ebb43aba757d6 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: scan-build 8.0.0 --- M src/device/hypertransport.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/34292/2
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34292 )
Change subject: device/hypertransport.c: Remove dead assignment ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34292/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34292/1//COMMIT_MSG@7 PS1, Line 7: device
device/hypertransport. […]
Done
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34292 )
Change subject: device/hypertransport.c: Remove dead assignment ......................................................................
device/hypertransport.c: Remove dead assignment
last_unitid is immediately overwritten in the do loop, so this assignment is not needed. This a relic from old code that commit 13f1c2af8b made obsolete, but was never removed.
Change-Id: I2eecddd025f7a64b0a70fc07a61ebb43aba757d6 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: scan-build 8.0.0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/34292 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/device/hypertransport.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/device/hypertransport.c b/src/device/hypertransport.c index ccad5ce..027c3ef 100644 --- a/src/device/hypertransport.c +++ b/src/device/hypertransport.c @@ -291,7 +291,6 @@ prev.freq_cap_off = PCI_HT_CAP_HOST_FREQ_CAP;
/* If present, assign unitid to a hypertransport chain. */ - last_unitid = min_unitid -1; max_unitid = next_unitid = min_unitid; do { u8 pos;
-
Angel Pons (Code Review) -
Jacob Garber (Code Review)
-
Martin Roth (Code Review)