Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35950 )
Change subject: ec/acpi/ec.c Link EC code in bootblock & verstage ......................................................................
ec/acpi/ec.c Link EC code in bootblock & verstage
This allows to read and set bits in the EC ram in the bootblock or verstage. This can be useful if one needs to read a keyboard key as an input for get_recovery_mode_switch in vboot.
Change-Id: I20b2264012b2a364a4157d85bfe5a2303cc5e677 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/ec/acpi/Makefile.inc 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/35950/1
diff --git a/src/ec/acpi/Makefile.inc b/src/ec/acpi/Makefile.inc index fae8fbf..34c113b 100644 --- a/src/ec/acpi/Makefile.inc +++ b/src/ec/acpi/Makefile.inc @@ -1,7 +1,9 @@ ifeq ($(CONFIG_EC_ACPI),y)
-ramstage-y += ec.c +bootblock-y += ec.c +verstage-y += ec.c romstage-y += ec.c +ramstage-y += ec.c smm-y += ec.c
endif
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35950 )
Change subject: ec/acpi/ec.c Link EC code in bootblock & verstage ......................................................................
Patch Set 1: Code-Review+2
Hello Patrick Rudolph, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35950
to look at the new patch set (#2).
Change subject: ec/acpi/ec.c Link EC code in bootblock & verstage ......................................................................
ec/acpi/ec.c Link EC code in bootblock & verstage
This allows to read and set bits in the EC ram in the bootblock or verstage. This can be useful if one needs to read a keyboard key as an input for get_recovery_mode_switch in vboot.
Change-Id: I20b2264012b2a364a4157d85bfe5a2303cc5e677 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/ec/acpi/Makefile.inc 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/35950/2
Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35950 )
Change subject: ec/acpi/ec.c Link EC code in bootblock & verstage ......................................................................
ec/acpi/ec.c Link EC code in bootblock & verstage
This allows to read and set bits in the EC ram in the bootblock or verstage. This can be useful if one needs to read a keyboard key as an input for get_recovery_mode_switch in vboot.
Change-Id: I20b2264012b2a364a4157d85bfe5a2303cc5e677 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/35950 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/ec/acpi/Makefile.inc 1 file changed, 3 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/ec/acpi/Makefile.inc b/src/ec/acpi/Makefile.inc index fae8fbf..34c113b 100644 --- a/src/ec/acpi/Makefile.inc +++ b/src/ec/acpi/Makefile.inc @@ -1,7 +1,9 @@ ifeq ($(CONFIG_EC_ACPI),y)
-ramstage-y += ec.c +bootblock-y += ec.c +verstage-y += ec.c romstage-y += ec.c +ramstage-y += ec.c smm-y += ec.c
endif
-
Arthur Heymans (Code Review) -
Patrick Rudolph (Code Review)